linux-kernel - Re: [PATCH 3/3] dell-wmi: Don't report keypresses on keybord illumination change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201412040031.39891@pali>
Date:	Thu, 4 Dec 2014 00:31:39 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	mjg59@...f.ucam.org, dvhart@...radead.org, pavel@....cz,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] dell-wmi: Don't report keypresses on keybord illumination change

On Thursday 04 December 2014 00:16:23 Gabriele Mazzotta wrote:
> Keyboard illumination level changes are performed by the BIOS,
> so no events should be reported on keypress. This is already
> done on systems using the legacy keymap, do it also for
> systems that don't use it.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
> ---

Tested-by: Pali Rohár <pali.rohar@...il.com>
CC: stable@...r.kernel.org

Tested on Latitude E6440 and now userspace does not receive 
KEY_KBDILLUMTOGGLE event, so does not try to change keyboard 
backlight (which is already done by BIOS when key is pressed).

I suggest to backport this patch to stable kernels because this 
problem is in all kernel versions which have dell-wmi.c driver.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)