linux-kernel - Re: [PATCH v9 3/8] devicetree: mfd: Add new SKY81452 mfd binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001701d00eaa$cdd0d970$69728c50$%han@samsung.com>
Date:	Wed, 03 Dec 2014 12:39:55 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Gyungoh Yoo' <gyungoh@...il.com>,
	'Lee Jones' <lee.jones@...aro.org>
Cc:	sameo@...ux.intel.com, cooloney@...il.com, broonie@...nel.org,
	lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	treding@...dia.com, florian.vaussard@...l.ch, trivial@...nel.org,
	linux@...ck-us.net, andrew@...n.ch, jic23@...nel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH v9 3/8] devicetree: mfd: Add new SKY81452 mfd binding

On Wednesday, December 03, 2014 12:09 PM, Gyungoh Yoo wrote:
> On Tue, Dec 02, 2014 at 02:07:27PM +0000, Lee Jones wrote:
> > This requires a DT Ack.
> 
> I think I need to double-check the recipients.
> Thank you for the comment.

Yes, right.
We should be careful when creating new DT properties.
This is because DT can be handled as ABI. Thus, Ack from
DT maintainers is necessary for merging new DT properties,
even though other subsystem maintainers or reviews gave
Ack for this.

Best regards,
Jingoo Han

> 
> >
> > > From: Gyungoh Yoo <jack.yoo@...worksinc.com>
> > >
> > > Signed-off-by: Gyungoh Yoo <jack.yoo@...worksinc.com>
> > > ---
> > > Changes v9:
> > > Nothing
> > >
> > > Changes v8:
> > > Made up the example for backlight DT
> > >
> > > Changes v7:
> > > Nothing
> > >
> > > Changes v6:
> > > Nothing
> > >
> > > Changes v5:
> > > Changed DT for regulator : 'lout' node should be defined under 'regulator'
> > > Removed compatible string from sky81452-regulator driver
> > >
> > > Changes v4:
> > > Nothing
> > >
> > > Changes v3:
> > > Nothing
> > >
> > > Changes v2:
> > > Added reg attribute for I2C slave address
> > >
> > >  Documentation/devicetree/bindings/mfd/sky81452.txt | 36 ++++++++++++++++++++++
> > >  1 file changed, 36 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/sky81452.txt
> b/Documentation/devicetree/bindings/mfd/sky81452.txt
> > > new file mode 100644
> > > index 0000000..ab71473
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/sky81452.txt
> > > @@ -0,0 +1,36 @@
> > > +SKY81452 bindings
> > > +
> > > +Required properties:
> > > +- compatible	: Must be "skyworks,sky81452"
> > > +- reg		: I2C slave address
> > > +
> > > +Required child nodes:
> > > +- backlight	: container node for backlight following the binding
> > > +		in video/backlight/sky81452-backlight.txt
> > > +- regulator	: container node for regulators following the binding
> > > +		in regulator/sky81452-regulator.txt
> > > +
> > > +Example:
> > > +
> > > +	sky81452@2c {
> > > +		compatible = "skyworks,sky81452";
> > > +		reg = <0x2c>;
> > > +
> > > +		backlight {
> > > +			compatible = "skyworks,sky81452-backlight";
> > > +			name = "pwm-backlight";
> > > +			skyworks,en-channels = <0x3f>;
> > > +			skyworks,ignore-pwm;
> > > +			skyworks,phase-shift;
> > > +			skyworks,ovp-level = <20>;
> > > +			skyworks,current-limit = <2300>;
> > > +		};
> > > +
> > > +		regulator {
> > > +			lout {
> > > +				regulator-name = "sky81452-lout";
> > > +				regulator-min-microvolt = <4500000>;
> > > +				regulator-max-microvolt = <8000000>;
> > > +			};
> > > +		};
> > > +	};
> >
> > --
> > Lee Jones
> > Linaro STMicroelectronics Landing Team Lead
> > Linaro.org │ Open source software for ARM SoCs
> > Follow Linaro: Facebook | Twitter | Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/