linux-kernel - Re: [PATCH v15 06/12] dt-bindings: add document for dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417598398.5124.2.camel@pengutronix.de>
Date:	Wed, 03 Dec 2014 10:19:58 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Andy Yan <andy.yan@...k-chips.com>
Cc:	Mark Rutland <mark.rutland@....com>, heiko@...ech.de,
	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	ykk@...k-chips.com, devel@...verdev.osuosl.org,
	Pawel Moll <pawel.moll@....com>,
	linux-rockchip@...ts.infradead.org,
	Grant Likely <grant.likely@...aro.org>,
	Dave Airlie <airlied@...hat.com>, jay.xu@...k-chips.com,
	devicetree@...r.kernel.org, Zubair.Kakakhel@...tec.com,
	Arnd Bergmann <arnd@...db.de>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Inki Dae <inki.dae@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Sean Paul <seanpaul@...omium.org>, rmk+kernel@....linux.org.uk,
	mark.yao@...k-chips.com, fabio.estevam@...escale.com,
	Josh Boyer <jwboyer@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, djkurtz@...gle.com,
	Kumar Gala <galak@...eaurora.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	vladimir_zapolskiy@...tor.com, Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

Hi Andy,

Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan:
> >> +Required properities:
> >> +- compatible: platform specific such as:
> >> +   * "fsl,imx6q-hdmi"
> >> +   * "fsl,imx6dl-hdmi"
> >> +   * "rockchip,rk3288-dw-hdmi"
> > I think we should add a common compatible value "snps,dw-hdmi-tx" here:
> >
> > 	compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx";
> >
>       How about "snps,dw-hdmi", because the driver is not only about
>    hdmi tx, but also include hdmi phy.

Synopsys call the whole module
"DesignWare HDMI Transmitter (TX) IP Solution":

https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_tx
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_tx

That includes the PHY. I'd prefer keeping the -tx in there to
differentiate from a possible future "snps,dw-hdmi-rx":

https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_rx
https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_rx

>        If we add such compatible value, do we have to implement another
>     platform driver like dw_hdmi-pltfm.c with the 
> compatible="snps,dw-hdmi" ,
>     or just include the compatible value in dw_hdmi-imx.c and 
> dw_hdmi-rockchip.c?

That common compatible doesn't have to be used by any driver. It's just
there to show these are the same/similar IP core.
If a common driver without any SoC specific knowledge could be written,
that one would match against the common compatible.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/