linux-kernel - Re: [PATCH] mtd: nand: gpmi: remove deprecated comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141203003050.GA7869@shldeISGChi005.sh.intel.com>
Date:	Wed, 3 Dec 2014 08:30:50 +0800
From:	Huang Shijie <shijie.huang@...el.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, Huang Shijie <shijie8@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mtd: nand: gpmi: remove deprecated comment

On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote:
> Now that we have raw functions properly implemented we can remove this
> FIXME.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 4f3851a..5d2cc9e 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1294,14 +1294,6 @@ exit_auxiliary:
>   * ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an
>   * ECC-based or raw view of the page is implicit in which function it calls
>   * (there is a similar pair of ECC-based/raw functions for writing).
> - *
> - * FIXME: The following paragraph is incorrect, now that there exist
> - * ecc.read_oob_raw and ecc.write_oob_raw functions.
> - *
> - * Since MTD assumes the OOB is not covered by ECC, there is no pair of
> - * ECC-based/raw functions for reading or or writing the OOB. The fact that the
> - * caller wants an ECC-based or raw view of the page is not propagated down to
> - * this driver.
>   */
>  static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
>  				int page)
Acked-by: Huang Shijie <shijie.huang@...el.com>	
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/