linux-kernel - Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Dec 2014 16:37:57 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anjana Sasindran <anjanasasindran123@...il.com>
Cc:	soren.brinkmann@...inx.com, laurent.pinchart@...asonboard.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]
 staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a
 line after declaration

On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
> 
> WARNING:Missing a blank line after declaration
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@...il.com>
> ---
>  drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 7202d8e..5fa813d 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>  	/* register div per output */
>  	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
>  		const char *clkout_name;
> +		
>  		if (of_property_read_string_index(np, "clock-output-names", i,
>  						  &clkout_name)) {
>  			dev_err(&pdev->dev,
> -- 
> 1.9.1

ALWAYS run your patches through checkpatch.pl so you don't get angry
emails from maintainers telling you that you added a warning with a
patch you were trying to get applied to remove a warning, making this a
pointless exercise :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/