linux-kernel - Re: [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547EFF43.4060207@redhat.com>
Date:	Wed, 03 Dec 2014 13:17:07 +0100
From:	Tomas Henzl <thenzl@...hat.com>
To:	Sreekanth Reddy <sreekanth.reddy@...gotech.com>, jejb@...nel.org,
	hch@...radead.org
CC:	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	JBottomley@...allels.com, Sathya.Prakash@...gotech.com,
	Nagalakshmi.Nandigama@...gotech.com, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."

On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
> This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed
> ("mpt2sas: Remove phys on topology change")
>
> Reverting the previous mpt2sas drives patch changes,
> since we will observe below issue
>
> Issue:
> Drives connected Enclosure/Expander will unregister with
> SCSI Transport Layer, if any one remove and add expander
> cable with in DMD (Device Missing Delay) time period or
> even any one power-off and power-on the Enclosure with in
> the DMD period.

We were not able to reproduce the issue which the original patch
should have fixed, so it's fine to remove it.

Reviewed-by: Tomas Henzl <thenzl@...hat.com>

> Cc: <stable@...r.kernel.org>
> Cc: Tomas Henzl <thenzl@...hat.com>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@...gotech.com>
> ---
>  drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c
> index 0d1d064..e689bf2 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c
> @@ -1006,12 +1006,9 @@ mpt2sas_transport_update_links(struct MPT2SAS_ADAPTER *ioc,
>  		    &mpt2sas_phy->remote_identify);
>  		_transport_add_phy_to_an_existing_port(ioc, sas_node,
>  		    mpt2sas_phy, mpt2sas_phy->remote_identify.sas_address);
> -	} else {
> +	} else
>  		memset(&mpt2sas_phy->remote_identify, 0 , sizeof(struct
>  		    sas_identify));
> -		_transport_del_phy_from_an_existing_port(ioc, sas_node,
> -		    mpt2sas_phy);
> -	}
>  
>  	if (mpt2sas_phy->phy)
>  		mpt2sas_phy->phy->negotiated_linkrate =

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/