linux-kernel - Re: ALSA: ctxfi: Delete an unnecessary check before kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h61dssy5n.wl-tiwai@suse.de>
Date:	Wed, 03 Dec 2014 13:41:56 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: ALSA: ctxfi: Delete an unnecessary check before kfree()

At Wed, 03 Dec 2014 12:38:51 +0100,
SF Markus Elfring wrote:
> 
> >>   Deletion of an unnecessary check before the function call "kfree"
> >>   One function call less in get_daio_rsc() after error detection
> > 
> > In these cases, the changes aren't so straightforward, and they don't
> > improve the readability.
> 
> How do you prefer to improve the affected source code here?

Don't touch then.  There are no bugs to fix there.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/