| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141203140136.12997331@free-electrons.com> Date: Wed, 3 Dec 2014 14:01:36 +0100 From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> To: Michael Ellerman <mpe@...erman.id.au> Cc: Tim Bird <tim.bird@...ymobile.com>, Shuah Khan <shuahkh@....samsung.com>, "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>, Josh Triplett <josh@...htriplett.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-embedded@...r.kernel.org" <linux-embedded@...r.kernel.org> Subject: Re: [PATCH v5] selftest: size: Add size test for Linux kernel Michael, Tim, On Wed, 03 Dec 2014 14:43:11 +1100, Michael Ellerman wrote: > > diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile > > new file mode 100644 > > index 0000000..47f8e9c > > --- /dev/null > > +++ b/tools/testing/selftests/size/Makefile > > @@ -0,0 +1,15 @@ > > +#ifndef CC > > + CC = $(CROSS_COMPILE)gcc > > +#endif > > I think the following is preferable: > > CC := $(CROSS_COMPILE)$(CC) It is even more necessary that #ifndef and #endif don't exist in make. They are just comments, and therefore, ignored. Seems like Tim does too much C :-) Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists