linux-kernel - Re: [RESEND PATCH] ima: Fix build failure on powerpc when TCG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417618130.10667.102.camel@dhcp-9-2-203-236.watson.ibm.com>
Date:	Wed, 03 Dec 2014 09:48:50 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	linux-kernel@...r.kernel.org, d.kasatkin@...sung.com,
	james.l.morris@...cle.com, serge@...lyn.com,
	linux-ima-devel@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org,
	Lo Hon Ching <lo1@...ibm.com>,
	Ashley Lai <ashley@...leylai.com>,
	George Wilson <gcwilson@...ibm.com>
Subject: Re: [RESEND PATCH] ima: Fix build failure on powerpc when
 TCG_IBMVTPM dependencies are not met

On Wed, 2014-12-03 at 17:04 +1100, Michael Ellerman wrote: 
> On powerpc we can end up with IMA=y and PPC_PSERIES=n which leads to:
> 
>   warning: (IMA) selects TCG_IBMVTPM which has unmet direct dependencies (TCG_TPM && PPC_PSERIES)
>   tpm_ibmvtpm.c:(.text+0x14f3e8): undefined reference to `.plpar_hcall_norets'
> 
> I'm not sure why IMA needs to select those user-visible symbols, but if
> it must then the simplest fix is to just express the proper dependencies
> on the select.

On systems without a TPM, IMA goes into a "by-pass" mode, which stores
the measurements without extending the TPM PCR.  On Power, there isn't a
HW TPM, but on Power running PowerVM there is a virtual TPM(vTPM).  On
Power running PowerKVM there isn't support for vTPM, yet.  The Kconfig
needs to differentiate between the two.

> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>

[CC'ing: Vicky(Lo, Hon Ching), Ashley Lai, George Wilson]
Sorry, I'm still waiting to hear back from the developers/testers.

Mimi

> ---
>  security/integrity/ima/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Could someone please pick this up?
> 
> diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
> index e099875643c5..b51668d04f9d 100644
> --- a/security/integrity/ima/Kconfig
> +++ b/security/integrity/ima/Kconfig
> @@ -10,7 +10,7 @@ config IMA
>  	select CRYPTO_HASH_INFO
>  	select TCG_TPM if HAS_IOMEM && !UML
>  	select TCG_TIS if TCG_TPM && X86
> -	select TCG_IBMVTPM if TCG_TPM && PPC64
> +	select TCG_IBMVTPM if TCG_TPM && PPC_PSERIES
>  	help
>  	  The Trusted Computing Group(TCG) runtime Integrity
>  	  Measurement Architecture(IMA) maintains a list of hash


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/