Date:	Wed, 3 Dec 2014 16:24:03 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Andrew Victor <linux@...im.org.za>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, "Arnd Bergmann" <arnd@...db.de>,
	Jean-Jacques Hiblot <jjhiblot@...phandler.com>
Subject: Re: [PATCH v4 05/11] memory: add Atmel EBI (External Bus Interface)
 driver

Le 02/12/2014 09:47, Boris Brezillon a écrit :
> The EBI (External Bus Interface) is used to access external peripherals
> (NOR, SRAM, NAND, and other specific devices like ethernet controllers).
> Each device is assigned a CS line and an address range and can have its
> own configuration (timings, access mode, bus width, ...).
> This driver provides a generic DT binding to configure a device according
> to its requirements.
> For specific device controllers (like the NAND one) the SMC timings
> should be configured by the controller driver through the matrix and
> smc syscon regmaps.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...phandler.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> ---
> 
> Changes since v3:
>  - use syscon_regmap_lookup_by_phandle instead of of_parse_phandle +
>    syscon_node_to_regmap
>  - drop AT91_EBICSA_REGFIELD and AT91_MULTI_EBICSA_REGFIELD macros
> 
>  drivers/memory/Kconfig     |  11 +
>  drivers/memory/Makefile    |   1 +
>  drivers/memory/atmel-ebi.c | 618 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 630 insertions(+)
>  create mode 100644 drivers/memory/atmel-ebi.c
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 6d91c27..dfe24a2 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -17,6 +17,17 @@ config ATMEL_SDRAMC
>  	  Starting with the at91sam9g45, this controller supports SDR, DDR and
>  	  LP-DDR memories.
>  
> +config ATMEL_EBI
> +	bool "Atmel EBI driver"
> +	default y
> +	depends on ARCH_AT91 && OF
> +	select MFD_SYSCON
> +	help
> +	  Driver for Atmel EBI controller.
> +	  Used to configure the EBI (external bus interface) when the device-
> +	  tree is used. This bus supports NANDs, external ethernet controller,
> +	  SRAMs, ATA devices, etc.
> +
>  config TI_AEMIF
>  	tristate "Texas Instruments AEMIF driver"
>  	depends on (ARCH_DAVINCI || ARCH_KEYSTONE) && OF
> diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile
> index c32d319..7ca2c19 100644
> --- a/drivers/memory/Makefile
> +++ b/drivers/memory/Makefile
> @@ -6,6 +6,7 @@ ifeq ($(CONFIG_DDR),y)
>  obj-$(CONFIG_OF)		+= of_memory.o
>  endif
>  obj-$(CONFIG_ATMEL_SDRAMC)	+= atmel-sdramc.o
> +obj-$(CONFIG_ATMEL_EBI)		+= atmel-ebi.o
>  obj-$(CONFIG_TI_AEMIF)		+= ti-aemif.o
>  obj-$(CONFIG_TI_EMIF)		+= emif.o
>  obj-$(CONFIG_FSL_CORENET_CF)	+= fsl-corenet-cf.o
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> new file mode 100644
> index 0000000..8702694
> --- /dev/null
> +++ b/drivers/memory/atmel-ebi.c
> @@ -0,0 +1,618 @@
> +/*
> + * EBI driver for Atmel SAM9 chips

Not only SAM9: remove it or add SAMA5.

> + * inspired by the fsl weim bus driver
> + *
> + * Copyright (C) 2013 JJ Hiblot.
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/io.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/mfd/syscon/atmel-matrix.h>
> +#include <linux/mfd/syscon/atmel-smc.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/regmap.h>
> +
> +struct at91sam9_smc_timings {
> +	u32 ncs_rd_setup_ns;
> +	u32 nrd_setup_ns;
> +	u32 ncs_wr_setup_ns;
> +	u32 nwe_setup_ns;
> +	u32 ncs_rd_pulse_ns;
> +	u32 nrd_pulse_ns;
> +	u32 ncs_wr_pulse_ns;
> +	u32 nwe_pulse_ns;
> +	u32 nrd_cycle_ns;
> +	u32 nwe_cycle_ns;
> +	u32 tdf_ns;
> +};
> +
> +struct at91sam9_smc_generic_fields {
> +	struct regmap_field *setup;
> +	struct regmap_field *pulse;
> +	struct regmap_field *cycle;
> +	struct regmap_field *mode;
> +};
> +
> +struct at91sam9_ebi_dev_config {
> +	struct at91sam9_smc_timings timings;
> +	u32 mode;
> +};
> +
> +struct at91_ebi;
> +
> +struct at91_ebi_dev {
> +	struct device_node *np;
> +	struct at91_smc_timings *timings;
> +	struct at91_ebi *ebi;
> +	u32 mode;
> +	int cs;
> +	void *config;
> +};
> +
> +struct at91_ebi_caps {
> +	unsigned int available_cs;
> +	const struct reg_field *ebi_csa;
> +	int (*xlate_config)(struct at91_ebi_dev *ebid);
> +	int (*apply_config)(struct at91_ebi_dev *ebid);
> +	int (*init)(struct at91_ebi *ebi);
> +};
> +
> +struct at91_ebi {
> +	struct clk *clk;
> +	struct regmap *smc;
> +	struct regmap *matrix;
> +
> +	struct regmap_field *ebi_csa;
> +
> +	struct device *dev;
> +	const struct at91_ebi_caps *caps;
> +	struct at91_ebi_dev *devs[AT91_MATRIX_EBI_NUM_CS];
> +	void *priv;
> +};
> +
> +static u32 at91sam9_smc_setup_ns_to_cycles(unsigned int clk_rate,
> +					   u32 timing_ns)
> +{
> +	u32 clk_period = DIV_ROUND_UP(NSEC_PER_SEC, clk_rate);
> +	u32 coded_cycles = 0;
> +	u32 cycles;
> +
> +	cycles = DIV_ROUND_UP(timing_ns, clk_period);
> +	if (cycles / 32) {

I know it is the formula from the datasheet but please add a note to
refer to it.
So, a comment here or at the beginning of the function is needed.

> +		coded_cycles |= 1 << 5;
> +		if (cycles < 128)
> +			cycles = 0;
> +	}
> +
> +	coded_cycles |= cycles % 32;
> +
> +	return coded_cycles;
> +}
> +
> +static u32 at91sam9_smc_pulse_ns_to_cycles(unsigned int clk_rate,
> +					   u32 timing_ns)
> +{
> +	u32 clk_period = DIV_ROUND_UP(NSEC_PER_SEC, clk_rate);
> +	u32 coded_cycles = 0;
> +	u32 cycles;
> +
> +	cycles = DIV_ROUND_UP(timing_ns, clk_period);
> +	if (cycles / 64) {

Ditto.

> +		coded_cycles |= 1 << 6;
> +		if (cycles < 256)
> +			cycles = 0;
> +	}
> +
> +	coded_cycles |= cycles % 64;
> +
> +	return coded_cycles;
> +}
> +
> +static u32 at91sam9_smc_cycle_ns_to_cycles(unsigned int clk_rate,
> +					   u32 timing_ns)
> +{
> +	u32 clk_period = DIV_ROUND_UP(NSEC_PER_SEC, clk_rate);
> +	u32 coded_cycles = 0;
> +	u32 cycles;
> +
> +	cycles = DIV_ROUND_UP(timing_ns, clk_period);
> +	if (cycles / 128) {

Ditto.

> +		coded_cycles = cycles / 256;
> +		cycles %= 256;
> +		if (cycles >= 128) {
> +			coded_cycles++;
> +			cycles = 0;
> +		}
> +
> +		if (coded_cycles > 0x3) {
> +			coded_cycles = 0x3;
> +			cycles = 0x7f;
> +		}
> +
> +		coded_cycles <<= 7;
> +	}
> +
> +	coded_cycles |= cycles % 128;
> +
> +	return coded_cycles;
> +}
> +
> +static int at91sam9_ebi_apply_config(struct at91_ebi_dev *ebid)
> +{
> +	unsigned int clk_rate = clk_get_rate(ebid->ebi->clk);
> +	struct at91sam9_ebi_dev_config *config = ebid->config;
> +	struct at91sam9_smc_timings *timings = &config->timings;
> +	struct at91sam9_smc_generic_fields *fields = ebid->ebi->priv;
> +	u32 val;
> +
> +	val = at91sam9_smc_setup_ns_to_cycles(clk_rate,
> +					      timings->ncs_rd_setup_ns) << 24;
> +	val |= at91sam9_smc_setup_ns_to_cycles(clk_rate,
> +					       timings->nrd_setup_ns) << 16;
> +	val |= at91sam9_smc_setup_ns_to_cycles(clk_rate,
> +					       timings->ncs_wr_setup_ns) << 8;

Well, I know it's easy to retrieve the meaning of these constants but
please I want a #define'd constant everywhere.


> +	val |= at91sam9_smc_setup_ns_to_cycles(clk_rate,
> +					       timings->nwe_setup_ns);
> +	regmap_fields_write(fields->setup, ebid->cs, val);
> +
> +	val = at91sam9_smc_pulse_ns_to_cycles(clk_rate,
> +					      timings->ncs_rd_pulse_ns) << 24;
> +	val |= at91sam9_smc_pulse_ns_to_cycles(clk_rate,
> +					       timings->nrd_pulse_ns) << 16;
> +	val |= at91sam9_smc_pulse_ns_to_cycles(clk_rate,
> +					       timings->ncs_wr_pulse_ns) << 8;
> +	val |= at91sam9_smc_pulse_ns_to_cycles(clk_rate,
> +					       timings->nwe_pulse_ns);
> +	regmap_fields_write(fields->pulse, ebid->cs, val);
> +
> +	val = at91sam9_smc_cycle_ns_to_cycles(clk_rate,
> +					      timings->nrd_cycle_ns) << 16;
> +	val |= at91sam9_smc_cycle_ns_to_cycles(clk_rate,
> +					       timings->nwe_cycle_ns);
> +	regmap_fields_write(fields->cycle, ebid->cs, val);
> +
> +	val = DIV_ROUND_UP(timings->tdf_ns, clk_rate);
> +	if (val > 16)
> +		val = 16;

Ditto.


> +	regmap_fields_write(fields->mode, ebid->cs, config->mode | val << 16);
> +
> +	return 0;
> +}
> +
> +static int at91sam9_smc_xslate_timings(struct at91_ebi_dev *ebid)
> +{
> +	struct at91sam9_ebi_dev_config *config = ebid->config;
> +	struct at91sam9_smc_timings *timings;
> +	struct device_node *np = ebid->np;
> +
> +	timings = &config->timings;
> +
> +	of_property_read_u32(np, "atmel,ncs-rd-setup-ns",
> +			     &timings->ncs_rd_setup_ns);
> +	of_property_read_u32(np, "atmel,nrd-setup-ns",
> +			     &timings->nrd_setup_ns);
> +	of_property_read_u32(np, "atmel,ncs-wr-setup-ns",
> +			     &timings->ncs_wr_setup_ns);
> +	of_property_read_u32(np, "atmel,nwe-setup-ns",
> +			     &timings->nwe_setup_ns);
> +	of_property_read_u32(np, "atmel,ncs-rd-pulse-ns",
> +			     &timings->ncs_rd_pulse_ns);
> +	of_property_read_u32(np, "atmel,nrd-pulse-ns",
> +			     &timings->nrd_pulse_ns);
> +	of_property_read_u32(np, "atmel,ncs-wr-pulse-ns",
> +			     &timings->ncs_wr_pulse_ns);
> +	of_property_read_u32(np, "atmel,nwe-pulse-ns", &timings->nwe_pulse_ns);
> +	of_property_read_u32(np, "atmel,nwe-cycle-ns", &timings->nwe_cycle_ns);
> +	of_property_read_u32(np, "atmel,nrd-cycle-ns", &timings->nrd_cycle_ns);
> +	of_property_read_u32(np, "atmel,tdf-ns", &timings->tdf_ns);
> +
> +	return 0;
> +}
> +
> +static int at91sam9_ebi_xslate_config(struct at91_ebi_dev *ebid)
> +{
> +	struct at91sam9_ebi_dev_config *config = ebid->config;
> +	struct device_node *np = ebid->np;
> +	const char *tmp_str;
> +	u32 tmp;
> +	int ret;
> +
> +	config = devm_kzalloc(ebid->ebi->dev, sizeof(*config), GFP_KERNEL);
> +	if (!config)
> +		return -ENOMEM;
> +
> +	ebid->config = config;
> +
> +	ret = of_property_read_u32(np, "atmel,bus-width", &tmp);
> +	if (ret)
> +		return ret;
> +
> +	switch (tmp) {
> +	case 8:
> +		config->mode |= AT91_SMC_DBW_8;
> +		break;
> +
> +	case 16:
> +		config->mode |= AT91_SMC_DBW_16;
> +		break;
> +
> +	case 32:
> +		config->mode |= AT91_SMC_DBW_32;
> +		break;
> +
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	if (of_property_read_bool(np, "atmel,tdf-optimized"))
> +		config->mode |= AT91_SMC_TDFMODE_OPTIMIZED;
> +
> +	tmp_str = NULL;
> +	of_property_read_string(np, "atmel,byte-access-type", &tmp_str);
> +	if (tmp_str && !strcmp(tmp_str, "write"))
> +		config->mode |= AT91_SMC_BAT_WRITE;
> +
> +	tmp_str = NULL;
> +	of_property_read_string(np, "atmel,read-mode", &tmp_str);
> +	if (tmp_str && !strcmp(tmp_str, "nrd"))
> +		config->mode |= AT91_SMC_READMODE_NRD;
> +
> +	tmp_str = NULL;
> +	of_property_read_string(np, "atmel,write-mode", &tmp_str);
> +	if (tmp_str && !strcmp(tmp_str, "nwe"))
> +		config->mode |= AT91_SMC_WRITEMODE_NWE;
> +
> +	tmp_str = NULL;
> +	of_property_read_string(np, "atmel,exnw-mode", &tmp_str);
> +	if (tmp_str) {
> +		if (!strcmp(tmp_str, "frozen"))
> +			config->mode |= AT91_SMC_EXNWMODE_FROZEN;
> +		else if (!strcmp(tmp_str, "ready"))
> +			config->mode |= AT91_SMC_EXNWMODE_READY;
> +	}
> +
> +	tmp = 0;
> +	ret = of_property_read_u32(np, "atmel,page-mode", &tmp);
> +	if (!ret) {
> +		switch (tmp) {
> +		case 4:
> +			config->mode |= AT91_SMC_PS_4;
> +			break;
> +
> +		case 8:
> +			config->mode |= AT91_SMC_PS_8;
> +			break;
> +
> +		case 16:
> +			config->mode |= AT91_SMC_PS_16;
> +			break;
> +
> +		case 32:
> +			config->mode |= AT91_SMC_PS_32;
> +			break;
> +
> +		default:
> +			return -EINVAL;
> +		}
> +
> +		config->mode |= AT91_SMC_PMEN;
> +	}
> +
> +	return at91sam9_smc_xslate_timings(ebid);
> +}
> +
> +static int at91sam9_ebi_init(struct at91_ebi *ebi)
> +{
> +	struct at91sam9_smc_generic_fields *fields;
> +	struct reg_field field = REG_FIELD(0, 0, 31);
> +
> +	fields = devm_kzalloc(ebi->dev, sizeof(*fields), GFP_KERNEL);
> +	if (!fields)
> +		return -ENOMEM;
> +
> +	field.id_size = fls(ebi->caps->available_cs);
> +	field.id_offset = 0x10;

A #define'd constant here please...

> +
> +	field.reg = AT91SAM9_SMC_SETUP(AT91SAM9_SMC_GENERIC_OFFSET);
> +	fields->setup = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->setup))
> +		return PTR_ERR(fields->setup);
> +
> +	field.reg = AT91SAM9_SMC_PULSE(AT91SAM9_SMC_GENERIC_OFFSET);
> +	fields->pulse = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->pulse))
> +		return PTR_ERR(fields->pulse);
> +
> +	field.reg = AT91SAM9_SMC_CYCLE(AT91SAM9_SMC_GENERIC_OFFSET);
> +	fields->cycle = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->cycle))
> +		return PTR_ERR(fields->cycle);
> +
> +	field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC_OFFSET);
> +	fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->mode))
> +		return PTR_ERR(fields->mode);
> +
> +	ebi->priv = fields;
> +
> +	return 0;
> +}
> +
> +static int sama5d3_ebi_init(struct at91_ebi *ebi)
> +{
> +	struct at91sam9_smc_generic_fields *fields;
> +	struct reg_field field = REG_FIELD(0, 0, 31);
> +
> +	fields = devm_kzalloc(ebi->dev, sizeof(*fields), GFP_KERNEL);
> +	if (!fields)
> +		return -ENOMEM;
> +
> +	field.id_size = fls(ebi->caps->available_cs);
> +	field.id_offset = SAMA5_SMC_GENERIC_BLK_SZ;

...Just like here ^^^

> +
> +	field.reg = AT91SAM9_SMC_SETUP(SAMA5_SMC_GENERIC_OFFSET);
> +	fields->setup = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->setup))
> +		return PTR_ERR(fields->setup);
> +
> +	field.reg = AT91SAM9_SMC_PULSE(SAMA5_SMC_GENERIC_OFFSET);
> +	fields->pulse = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->pulse))
> +		return PTR_ERR(fields->pulse);
> +
> +	field.reg = AT91SAM9_SMC_CYCLE(SAMA5_SMC_GENERIC_OFFSET);
> +	fields->cycle = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->cycle))
> +		return PTR_ERR(fields->cycle);
> +
> +	field.reg = SAMA5_SMC_MODE(SAMA5_SMC_GENERIC_OFFSET);
> +	fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field);
> +	if (IS_ERR(fields->mode))
> +		return PTR_ERR(fields->mode);
> +
> +	ebi->priv = fields;
> +
> +	return 0;
> +}
> +
> +static int at91_ebi_dev_setup(struct at91_ebi *ebi, struct device_node *np)
> +{
> +	struct device *dev = ebi->dev;
> +	struct device_node *dev_np;
> +	struct at91_ebi_dev *ebid;
> +	u32 tmp;
> +	int ret;
> +
> +	dev_np = of_get_next_child(np, NULL);
> +	if (!dev_np)
> +		return -EINVAL;
> +
> +	if (!of_device_is_available(dev_np))
> +		return 0;
> +
> +	ebid = devm_kzalloc(ebi->dev, sizeof(*ebid), GFP_KERNEL);
> +	if (!ebid)
> +		return -ENOMEM;
> +
> +	ret = of_property_read_u32(dev_np, "reg" , &tmp);
> +	if (ret < 0) {
> +		dev_err(dev, "missing mandatory reg property\n");
> +		return ret;
> +	}
> +
> +	if (tmp > AT91_MATRIX_EBI_NUM_CS ||
> +	    !(BIT(tmp) & ebi->caps->available_cs)) {
> +		dev_err(dev, "invalid reg property\n");
> +		return -EINVAL;
> +	}
> +
> +	ebid->cs = tmp;
> +	ebid->np = np;
> +	ebid->ebi = ebi;
> +
> +	if (!of_property_read_bool(np, "atmel,generic-dev"))
> +		goto populate;
> +
> +	if (ebid->ebi->ebi_csa)
> +		regmap_field_update_bits(ebid->ebi->ebi_csa,
> +					 BIT(ebid->cs),
> +					 ~BIT(ebid->cs));
> +
> +	ret = ebid->ebi->caps->xlate_config(ebid);
> +	if (ret)
> +		return ret;
> +
> +	ret = ebid->ebi->caps->apply_config(ebid);
> +	if (ret)
> +		return ret;
> +	ebi->devs[ebid->cs] = ebid;
> +
> +populate:
> +	return of_platform_populate(np, of_default_bus_match_table, NULL, dev);
> +}
> +
> +static const struct reg_field at91sam9260_ebi_csa =
> +				REG_FIELD(AT91SAM9260_MATRIX_EBICSA_OFF, 0,
> +					  AT91_MATRIX_EBI_NUM_CS - 1);
> +
> +static const struct at91_ebi_caps at91sam9260_ebi_caps = {
> +	.available_cs = 0xff,
> +	.ebi_csa = &at91sam9260_ebi_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct reg_field at91sam9261_ebi_csa =
> +				REG_FIELD(AT91SAM9261_MATRIX_EBICSA_OFF, 0,
> +					  AT91_MATRIX_EBI_NUM_CS - 1);
> +
> +static const struct at91_ebi_caps at91sam9261_ebi_caps = {
> +	.available_cs = 0xff,
> +	.ebi_csa = &at91sam9261_ebi_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct reg_field at91sam9263_ebi0_csa =
> +				REG_FIELD(AT91SAM9263_MATRIX_EBI0CSA_OFF, 0,
> +					  AT91_MATRIX_EBI_NUM_CS - 1);
> +
> +static const struct at91_ebi_caps at91sam9263_ebi0_caps = {
> +	.available_cs = 0x3f,
> +	.ebi_csa = &at91sam9263_ebi0_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct reg_field at91sam9263_ebi1_csa =
> +				REG_FIELD(AT91SAM9263_MATRIX_EBI1CSA_OFF, 0,
> +					  AT91_MATRIX_EBI_NUM_CS - 1);
> +
> +static const struct at91_ebi_caps at91sam9263_ebi1_caps = {
> +	.available_cs = 0x7,
> +	.ebi_csa = &at91sam9263_ebi1_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct reg_field at91sam9g45_ebi_csa =
> +				REG_FIELD(AT91SAM9G45_MATRIX_EBICSA_OFF, 0,
> +					  AT91_MATRIX_EBI_NUM_CS - 1);
> +
> +static const struct at91_ebi_caps at91sam9g45_ebi_caps = {
> +	.available_cs = 0x3f,
> +	.ebi_csa = &at91sam9g45_ebi_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct at91_ebi_caps at91sam9x5_ebi_caps = {
> +	.available_cs = 0x3f,
> +	.ebi_csa = &at91sam9263_ebi0_csa,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = at91sam9_ebi_init,
> +};
> +
> +static const struct at91_ebi_caps sama5d3_ebi_caps = {
> +	.available_cs = 0xf,
> +	.xlate_config = at91sam9_ebi_xslate_config,
> +	.apply_config = at91sam9_ebi_apply_config,
> +	.init = sama5d3_ebi_init,
> +};
> +
> +static const struct of_device_id at91_ebi_id_table[] = {
> +	{
> +		.compatible = "atmel,at91sam9260-ebi",
> +		.data = &at91sam9260_ebi_caps,
> +	},
> +	{
> +		.compatible = "atmel,at91sam9261-ebi",
> +		.data = &at91sam9261_ebi_caps,
> +	},
> +	{
> +		.compatible = "atmel,at91sam9263-ebi0",
> +		.data = &at91sam9263_ebi0_caps,
> +	},
> +	{
> +		.compatible = "atmel,at91sam9263-ebi1",
> +		.data = &at91sam9263_ebi1_caps,
> +	},
> +	{
> +		.compatible = "atmel,at91sam9g45-ebi",
> +		.data = &at91sam9g45_ebi_caps,
> +	},
> +	{
> +		.compatible = "atmel,at91sam9x5-ebi",
> +		.data = &at91sam9x5_ebi_caps,
> +	},
> +	{
> +		.compatible = "atmel,sama5d3-ebi",
> +		.data = &sama5d3_ebi_caps,
> +	},
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, at91_ebi_id_table);
> +
> +static int at91_ebi_probe(struct platform_device *pdev)
> +{
> +	const struct of_device_id *match;
> +	struct device_node *child;
> +	struct at91_ebi *ebi;
> +	struct clk *clk;
> +	int ret;
> +
> +	match = of_match_device(at91_ebi_id_table, &pdev->dev);
> +	if (!match || !match->data)
> +		return -EINVAL;
> +
> +	ebi = devm_kzalloc(&pdev->dev, sizeof(*ebi), GFP_KERNEL);
> +	if (!ebi)
> +		return -ENOMEM;
> +
> +	ebi->caps = match->data;
> +	ebi->dev = &pdev->dev;
> +
> +	clk = devm_clk_get(&pdev->dev, NULL);
> +	if (IS_ERR(clk))
> +		return PTR_ERR(clk);
> +
> +	ebi->clk = clk;
> +
> +	ebi->smc = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
> +						   "atmel,smc");
> +	if (IS_ERR(ebi->smc))
> +		return PTR_ERR(ebi->smc);
> +
> +	/*
> +	 * The sama5d3 does not provide an EBICSA register and thus does need
> +	 * to access the matrix registers.
> +	 */
> +	if (ebi->caps->ebi_csa) {
> +		ebi->matrix =
> +			syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
> +							"atmel,matrix");
> +		if (IS_ERR(ebi->matrix))
> +			return PTR_ERR(ebi->matrix);
> +
> +		ebi->ebi_csa = regmap_field_alloc(ebi->matrix,
> +						  *ebi->caps->ebi_csa);
> +		if (IS_ERR(ebi->ebi_csa))
> +			return PTR_ERR(ebi->ebi_csa);
> +	}
> +
> +	ret = ebi->caps->init(ebi);
> +	if (ret)
> +		return ret;
> +
> +	for_each_child_of_node(pdev->dev.of_node, child) {
> +		ret = at91_ebi_dev_setup(ebi, child);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	return ret;
> +}
> +
> +static struct platform_driver at91_ebi_driver = {
> +	.driver = {
> +		.name = "atmel-ebi",
> +		.of_match_table	= at91_ebi_id_table,
> +	},
> +};
> +module_platform_driver_probe(at91_ebi_driver, at91_ebi_probe);
> +
> +MODULE_AUTHOR("JJ Hiblot");
> +MODULE_DESCRIPTION("Atmel's EBI driver");
> +MODULE_LICENSE("GPL");
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists