linux-kernel - Re: The DM_BUFIO_HASH_BITS is defined as 20, any plan to make it flexible?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141203161749.GA13117@redhat.com>
Date:	Wed, 3 Dec 2014 11:17:49 -0500
From:	Mike Snitzer <snitzer@...hat.com>
To:	device-mapper development <dm-devel@...hat.com>,
	zhangxiao <xiao.zhang@...driver.com>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org, agk@...hat.com
Subject: Re: The DM_BUFIO_HASH_BITS is defined as 20, any plan to make it
 flexible?

On Wed, Dec 03 2014 at  9:19am -0500,
Joe Thornber <thornber@...hat.com> wrote:

> On Tue, Dec 02, 2014 at 09:00:17AM -0500, Mike Snitzer wrote:
> > On Tue, Dec 02 2014 at  3:43am -0500,
> > zhangxiao <xiao.zhang@...driver.com> wrote:
> > 
> > > Hi Experts,
> > > 
> > > See drivers/md/dm-bufio.c as below:
> > >   50 /*
> > >   51  * Buffer hash
> > >   52  */
> > >   53 #define DM_BUFIO_HASH_BITS      20
> > >   54 #define DM_BUFIO_HASH(block) \
> > >   55         ((((block) >> DM_BUFIO_HASH_BITS) ^ (block)) & \
> > >   56          ((1 << DM_BUFIO_HASH_BITS) - 1))
> > > "drivers/md/dm-bufio.c" 1854L, 45375C
> > > 
> > > DM_BUFIO_HASH_BITS was defined as 20 and it maybe not fit for some
> > > use case with limited resources. Do we have any plan to make it more
> > > flexible? Like module parameter or something else?
> > 
> > No immediate plans.
> 
> That hash table has been replaced with a red/black tree.
> 
> https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-for-3.19&id=4e420c452b11edf9d510c8180ac66f529e5b6206

Ah yes, you'd think I'd have remembered that change.  Thanks for keeping
me honest Joe!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/