linux-kernel - Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Dec 2014 18:04:18 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
	linux-mm@...ck.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere

2014-12-03 16:54 GMT+01:00 Michal Hocko <mhocko@...e.cz>:
> On Wed 03-12-14 10:22:31, Johannes Weiner wrote:
>> On Tue, Dec 02, 2014 at 11:41:23PM +0100, Rickard Strandqvist wrote:
>> > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere.
>> >
>> > This was partially found by using a static code analysis program called cppcheck.
>> >
>> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> > ---
>> >  mm/memcontrol.c |    5 -----
>> >  1 file changed, 5 deletions(-)
>> >
>> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> > index d6ac0e3..5edd1fe 100644
>> > --- a/mm/memcontrol.c
>> > +++ b/mm/memcontrol.c
>> > @@ -4379,11 +4379,6 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
>> >  }
>> >  #endif /* CONFIG_NUMA */
>> >
>> > -static inline void mem_cgroup_lru_names_not_uptodate(void)
>> > -{
>> > -   BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
>> > -}
>>
>> That assertion doesn't work in an unused function, but we still want
>> this check.  Please move the BUILD_BUG_ON() to the beginning of
>> memcg_stat_show() instead.
>
> Ohh. I have completely missed the point of the check! Moving the check
> to memcg_stat_show sounds like a good idea.
>
> --
> Michal Hocko
> SUSE Labs

Hi

Ok, sure I'll fix that!

It will take a few days before I will have access to my workstation,
however, but the new patch on the way...

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/