linux-kernel - Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141203173441.GA12889@kroah.com>
Date:	Wed, 3 Dec 2014 09:34:41 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sean Cleator <seancleator@...mail.co.uk>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: dgnc: Fix long line coding style issues in
 dgnc_cls.h

On Wed, Dec 03, 2014 at 05:07:28PM +0000, Sean Cleator wrote:
> A patch to fix the rest of the long line warnings in the dgnc_cls.h file
> found by the checkpatch.pl tool
> 
> Signed-off-by: Sean Cleator <seancleator@...mail.co.uk>
> 
> ---
>  drivers/staging/dgnc/dgnc_cls.h | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
> index 465d79a..32034e4 100644
> --- a/drivers/staging/dgnc/dgnc_cls.h
> +++ b/drivers/staging/dgnc/dgnc_cls.h
> @@ -38,7 +38,10 @@
>  struct cls_uart_struct {
>  	u8 txrx;		/* WR  RHR/THR - Holding Reg */
>  	u8 ier;		/* WR  IER - Interrupt Enable Reg */
> -	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> +	u8 isr_fcr;		/*
> +				 * WR  ISR/FCR - Interrupt Status Reg/Fifo
> +				 * Control Reg
> +				 */
>  	u8 lcr;		/* WR  LCR - Line Control Reg */
>  	u8 mcr;		/* WR  MCR - Modem Control Reg */
>  	u8 lsr;		/* WR  LSR - Line Status Reg */
> @@ -61,8 +64,11 @@ struct cls_uart_struct {
>  #define UART_16654_FCR_RXTRIGGER_56	0x80
>  #define UART_16654_FCR_RXTRIGGER_60     0xC0
>  
> -#define UART_IIR_CTSRTS			0x20	/* Received CTS/RTS change of state */
> -#define UART_IIR_RDI_TIMEOUT		0x0C    /* Receiver data TIMEOUT */
> +#define UART_IIR_CTSRTS			0x20	/*
> +						 *  Received CTS/RTS change of
> +						 *  state
> +						 */

That's pretty ugly, don't you think?  How about putting the comments on
the line before the #define, instead of at the end?  That would make
things much nicer to read.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/