| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2645048.kv31YXMmsb@skinner> Date: Wed, 03 Dec 2014 19:25:25 +0100 From: Thomas Renninger <trenn@...e.de> To: Prarit Bhargava <prarit@...hat.com> Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org Subject: Re: [PATCH] tools, cpupower, fix return checks for sysfs_get_idlestate_count() On Monday, December 01, 2014 09:39:22 AM Prarit Bhargava wrote: > Red Hat and Fedora use a bug reporting tool that gathers data about > "broken" systems called sosreport. Among other things, it includes the > output of 'cpupower idle-info'. Executing 'cpupower idle-info' on a > system that has cpuidle disabled via 'cpuidle.off=1' results in a 300 > second hang in the cpupower application. > > ie) > [root@...el-brickland-05]# cpupower idle-info > Could not determine cpuidle driver > > Analyzing CPU 0: > Number of idle states: -19 > [hang] > > The problem is that the cpupower code only checks for a zero return from > sysfs_get_idlestate_count(). The function can return -ENODEV (-19) as > above. This patch fixes callers to sysfs_get_idlestate_count() to check > the right return values. > > Cc: Thomas Renninger <trenn@...e.de> > Cc: linux-pm@...r.kernel.org > Signed-off-by: Prarit Bhargava <prarit@...hat.com> Signed-off-by: Thomas Renninger <trenn@...e.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists