linux-kernel - Re: [patch] CodingStyle: add some more error handling guidelines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547F60E5.50705@broadcom.com>
Date:	Wed, 3 Dec 2014 20:13:41 +0100
From:	Arend van Spriel <arend@...adcom.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>,
	"Jonathan Corbet" <corbet@....net>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Coccinelle <cocci@...teme.lip6.fr>, <backports@...r.kernel.org>,
	"Johannes Berg" <johannes@...solutions.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [patch] CodingStyle: add some more error handling guidelines

On 12/03/14 17:00, SF Markus Elfring wrote:
>>> Which name pattern do you find more appropriate in such
>>> an use case?
>>
>> I think Dan wants the label to be descriptive about the tasks
>> needed in the exception handling itself.
>
> I would usually prefer also such a target-oriented labelling
> for the affected identifiers.
> How are the chances to express an expectation in this direction
> unambiguously for the proposed coding style update?
>
>
>> This makes sense as the exception handling steps may be reused
>> for different failures in the code.
>
> I would stress a different reason from my point of view.

I meant as apposed to using a goto-/source-oriented labelling. Please 
provide your point of view. That way the explanations given in this 
email exchange might be incorporated in the next round of the proposed 
update or at least be used as input.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/