linux-kernel - Re: [PATCH v2] context_tracking: Restore previous state in schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141204000137.GF31369@lerouge>
Date:	Thu, 4 Dec 2014 01:01:38 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	Andy Lutomirski <luto@...capital.net>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Richard Guy Briggs <rgb@...hat.com>,
	Eric Paris <eparis@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Jones <davej@...hat.com>, Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH v2] context_tracking: Restore previous state in
 schedule_user

On Wed, Dec 03, 2014 at 03:50:02PM -0800, Paul E. McKenney wrote:
> On Wed, Dec 03, 2014 at 03:37:08PM -0800, Andy Lutomirski wrote:
> > It appears that some SCHEDULE_USER (asm for schedule_user) callers
> > in arch/x86/kernel/entry_64.S are called from RCU kernel context,
> > and schedule_user will return in RCU user context.  This causes RCU
> > warnings and possible failures.
> > 
> > This is intended to be a minimal fix suitable for 3.18.
> > 
> > Reported-and-tested-by: Dave Jones <davej@...hat.com>
> > Cc: Oleg Nesterov <oleg@...hat.com>
> > Cc: Frédéric Weisbecker <fweisbec@...il.com>
> > Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>
> > Signed-off-by: Andy Lutomirski <luto@...capital.net>
> 
> Looks like the RCU entry/exit stuff is properly accounted for, so:
> 
> Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

Thanks a lot guys!

I'll take the patch. This just won't go for 3.18 I think, the issue
is there since the early days of context tracking.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/