Message-ID: <20141204073044.GF25806@verge.net.au>
Date:	Thu, 4 Dec 2014 16:30:45 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Magnus Damm <magnus.damm@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Kevin Hilman <khilman@...aro.org>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Philipp Zabel <philipp.zabel@...il.com>,
	Tomasz Figa <tomasz.figa@...il.com>, linux-sh@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/7] ARM: shmobile: R-Mobile: DT PM domain support

On Wed, Dec 03, 2014 at 02:41:40PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series enables DT support for PM domains on Renesas R-Mobile SoCs.
> 
> Currently it's limited to R-Mobile A1 (r8a7740), but given the similarity of
> the SYSC System-Controller on the various SH-Mobile/R-Mobile SoCs, and the
> abstraction of PM domains in DT, it should be sufficiently generic to handle
> other SoCs in the future (e.g. SH-Mobile AP4 (sh7372), SH-Mobile AG5 (sh73a0),
> R-Mobile APE6 (r8a73a4)). In fact preliminary patches for SH-Mobile AG5
> (sh73a0) that build on top of this have been posted before.
> 
> Functionality-wise, this behaves the same as the legacy (non-DT) version
> (modulo missing DT support in some device drivers).
> 
> Please apply, thanks!

Thanks, I have done so.

> 
> Dependencies:
>   - This is based on Simon Horman's renesas-devel-20141202-v3.18-rc7.
> 
> Changes compared to v5:
>   - Drop bindings and code for power-on/off latencies. They can be handled
>     later.  This means the whole series can go through Simon's tree now.
> 
> Changes compared to v4:
>   - Update for {at,de}tach_dev() taking a generic_pm_domain pointer
>     again,
> 
> Changes compared to v3 (more detailed changelogs in the individual patches):
>   - I dropped the patch to add preliminary PM domain latencies, as I want to do
>     more measurements for PM domains that are currently never powered off.
>     Values seem to range between 8.5 and 26 us, depending on the PM domain.
>   - I dropped all patches related to QoS device latencies, as these need more
>     discussion,
>   - The power-{on,off}-latency properties have been changed from a single value
>     to a list,
>   - Device save/restore state latencies have been dropped, as they're Linux
>     driver-specific, and thus don't belong in DT,
>   - Use proper pm_clk_create()/pm_clk_destroy(), and update for attach_dev()
>     returning an error code again,
>   - New patch to enable module clocks if !CONFIG_PM_RUNTIME,
>   - Always keep D4 powered, until the new Coresight code handles runtime
>     PM,
>   - Remove bogus power-domains properties from clock nodes, as these will not
>     be instantiated as platform devices,
>   - Add power-domains properties to the recently added TMU nodes,
>   - Added Acked-by, Reviewed-by.
> 
> Changes compared to v2 (more detailed changelogs in the individual patches):
>   - Minor changes to attach/detach callbacks,
>   - Really add the A4MP and D4 PM domains, as fixes are available (see
>     dependencies below),
>   - Scan DT topology to identify special PM domains (CPUs and console),
>   - Move PM domain power-on/off latencies to a separate patch.
> 
> Changes compared to v1 (more detailed changelogs in the individual patches):
>   - Several new patches: PM QoS device latencies in DT, attach/detach
>     callbacks,
>   - Run-Time management of the module clocks, making the hack in
>     drivers/sh/pm_runtime.c obsolete for DT platforms using genpd,
>   - Addition of PM QoS device latencies, specified from DT,
>   - Addition of build glue, so this builds and runs without additional
>     changes, incl. s2ram.
> 
> Geert Uytterhoeven (7):
>   PM / Domains: Add DT bindings for the R-Mobile System Controller
>   ARM: shmobile: R-Mobile: Use generic_pm_domain.attach_dev() for pm_clk
>     setup
>   ARM: shmobile: R-Mobile: Enable module clocks if !CONFIG_PM_RUNTIME
>   ARM: shmobile: R-Mobile: Store SYSC base address in rmobile_pm_domain
>   ARM: shmobile: R-Mobile: Add DT support for PM domains
>   ARM: shmobile: r8a7740 dtsi: Add PM domain support
>   drivers: sh: Disable PM runtime for multi-platform r8a7740 with genpd
> 
>  .../bindings/power/renesas,sysc-rmobile.txt        |  98 +++++++
>  arch/arm/boot/dts/r8a7740.dtsi                     |  99 ++++++++
>  arch/arm/mach-shmobile/Kconfig                     |   3 +-
>  arch/arm/mach-shmobile/pm-r8a7740.c                |  14 +
>  arch/arm/mach-shmobile/pm-rmobile.c                | 281 +++++++++++++++++++--
>  arch/arm/mach-shmobile/pm-rmobile.h                |   3 +-
>  arch/arm/mach-shmobile/pm-sh7372.c                 |  11 +
>  drivers/sh/pm_runtime.c                            |   2 +
>  8 files changed, 494 insertions(+), 17 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt
> 
> -- 
> 1.9.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists