linux-kernel - Re: [PATCH 0/3] Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201412041055.32689@pali>
Date:	Thu, 4 Dec 2014 10:55:32 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Alex Hung <alex.hung@...onical.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Gabriele Mazzotta <gabriele.mzt@...il.com>
Subject: Re: [PATCH 0/3] Dell Airplane Mode Switch driver

On Thursday 04 December 2014 09:16:25 Alex Hung wrote:
> HI Darren and Pali,
> 
> It was great that we had a lot of discussion but it seems Dell
> BIOS implementation varies from one series to another. Both
> work looks good either one is fine with me.
> 

Alex, am I right that your dell-wireless.c do nothing for laptops 
with HW switch (when CRBT returns 2 or 3)?

If yes, then for these laptops we do not need dell-wireless.c and 
my dell-rbtn.c is better.

> But I think I can do a little more: I am collecting a number
> of systems to try out these patches. This should help us
> determine which one work better and probably we can
> integrate.
> 

Yes, sure.

> Currently I have found four systems (including two Latitude,
> an Inspiron and a XPS with working method(ARBT) that Gabriele
> suggested). I can get other, ex. a Vostro, if needed.
> 

Do you know what should ARBT method do?

> I will test dell-wireless.c with Gabriele's suggestion and
> Pali's dell-rbtn.c (btw, will there be updates?). However, I
> will need a few days to do the comparison.
> 

Until we would know how to *properly* set soft rfkill state and 
what ARBT is doing on more machines, I'm not going to update my 
dell-rbtn.c (as it is for now complete).

Darren, I think that if we do not solve problem with duplicate 
key events (in dell-wireless.c) we should postpone these patches 
to later kernel version. It is better to not have such regression 
as it confuse software like NetworkManager which is widely used.

> Any suggested test cases?
> 

Check if wlan key is reported via WMI or AT Keyboard also without 
dell-wireless.c.

Check if dell-rbtn.c show correct hard rfkill state (on all 
tested machines) when pressing wlan key more times (or switching 
HW-slide switch).

> Cheers,
> Alex Hung
> 
> On Tue, Dec 2, 2014 at 4:42 PM, Pali Rohár 
<pali.rohar@...il.com> wrote:
> > On Wednesday 26 November 2014 00:05:28 Darren Hart wrote:
> >> On Sun, Nov 23, 2014 at 04:09:18PM +0100, Pali Rohár wrote:
> >> > This patch series add new acpi Dell Airplane Mode Switch
> >> > driver (DELLABCE and DELRBTN acpi devices). It provides
> >> > radio HW switch events (together with current state of
> >> > radio devices) and export them via rfkill interface.
> >> > These events are also used in dell-laptop driver instead
> >> > i8042 filter hook function (when acpi device is
> >> > available).
> >> > 
> >> > Pali Rohár (3):
> >> >   platform: x86: dell-rbtn: Dell Airplane Mode Switch
> >> >   driver platform: x86: dell-rbtn: Export notifier for
> >> >   other kernel modules platform: x86: dell-laptop: Use
> >> >   dell-rbtn instead i8042 filter when
> >> >   
> >> >     possible
> >> >  
> >> >  drivers/platform/x86/Kconfig       |   14 ++
> >> >  drivers/platform/x86/Makefile      |    1 +
> >> >  drivers/platform/x86/dell-laptop.c |   67 +++++++++-
> >> >  drivers/platform/x86/dell-rbtn.c   |  260
> >> >  ++++++++++++++++++++++++++++++++++++
> >> >  drivers/platform/x86/dell-rbtn.h   |   35 +++++
> >> >  5 files changed, 372 insertions(+), 5 deletions(-)
> >> >  create mode 100644 drivers/platform/x86/dell-rbtn.c
> >> >  create mode 100644 drivers/platform/x86/dell-rbtn.h
> >> 
> >> Alex, it is my understanding that this solution from Pali
> >> is a more complete solution to dealing with the variety of
> >> dell wireless buttons and rfkill mechanisms in the world
> >> today.
> >> 
> >> I currently have:
> >> 7c4d961 dell-wireless: new driver for dell wireless button
> >> for Windows 8 queued in for-next. If I have read your
> >> responses on this correctly, are we all in agreement that
> >> I should drop the above patch, and apply these?
> > 
> > Darren, it it truth that some laptops does not send keypress
> > event when Fn+wifi key is pressed (but only send ACPI
> > event), then really Alex's patch for input device is
> > needed. But it could be integrated into my driver. Also
> > Alex wrote something about ACPI events for laptops which
> > have wifi key instead HW switch. So before including this
> > patch into tree, I would like to hear what is problem with
> > my patch for laptops which have wifi key...
> > 
> > --
> > Pali Rohár
> > pali.rohar@...il.com

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)