linux-kernel - Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547FAFF6.3050800@rock-chips.com>
Date:	Thu, 04 Dec 2014 08:51:02 +0800
From:	Andy Yan <andy.yan@...k-chips.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	airlied@...ux.ie, Philipp Zabel <p.zabel@...gutronix.de>,
	heiko@...ech.de, fabio.estevam@...escale.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Josh Boyer <jwboyer@...hat.com>,
	Sean Paul <seanpaul@...omium.org>,
	Inki Dae <inki.dae@...sung.com>,
	Dave Airlie <airlied@...hat.com>,
	Arnd Bergmann <arnd@...db.de>,
	Lucas Stach <l.stach@...gutronix.de>,
	Zubair.Kakakhel@...tec.com, djkurtz@...gle.com, ykk@...k-chips.com,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	devel@...verdev.osuosl.org, devicetree@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, jay.xu@...k-chips.com,
	Pawel Moll <pawel.moll@....com>, mark.yao@...k-chips.com,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	vladimir_zapolskiy@...tor.com, Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge
 mode

Hi Russel:
On 2014年12月04日 07:40, Russell King - ARM Linux wrote:
> On Thu, Dec 04, 2014 at 12:56:24AM +0800, Andy Yan wrote:
>> Hi Russell:
>> On 2014年12月04日 00:33, Russell King - ARM Linux wrote:
>>> On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote:
>>>> On 2014年12月04日 00:11, Russell King - ARM Linux wrote:
>>>>> I meant that imx_hdmi_bind should be passed these, so that it needs to
>>>>> know nothing about the struct device beyond the generic device structure.
>>>>> In other words, the dw-hdmi core should not assume that the struct device
>>>>> is part of a platform device.
>>>>>
>>>>     if so, how about the device tree properties  ddc-i2c-bus, reg-io-width,
>>>> iahb, isfr,
>>>>    they are all found by device?
>>> If the device has a device tree node associated with it, it will have a
>>> non-NULL dev->of_node - which is part of the generic device structure.
>>>
>>    so , I just need get the resource and irq number in the
>> dw_hdmi-imx/rockchip ,than
>>    pass them to imx_hdmi_bind, as the properties ddc-i2c-bus, reg-io-width,
>> iahb,isfr, they
>>    are still can be handled in imx_hdmi_bind ?
> Basically, what I'm suggesting is just this change to imx_hdmi_bind():
>
>   int imx_hdmi_bind(struct device *dev, struct device *master,
> 		  void *data, struct drm_encoder *encoder,
> +		  const struct resource *iores, int irq,
> 		  const struct imx_hdmi_plat_data *plat_data)
>   {
> -	struct platform_device *pdev = to_platform_device(dev);
> ...
> 	}
>
> -	irq = platform_get_irq(pdev, 0);
> 	if (irq < 0)
> 		return irq;
> ...
> 		return ret;
>
> -	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 	hdmi->regs = devm_ioremap_resource(dev, iores);
> 	if (IS_ERR(hdmi->regs))
>
> and supplying those as arguments from the caller.
>
   got it, thanks, and also many thanks for Philipp


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/