linux-kernel - Re: [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <548051BE.3000602@amd.com>
Date:	Thu, 4 Dec 2014 14:21:18 +0200
From:	Oded Gabbay <oded.gabbay@....com>
To:	Sasha Levin <sasha.levin@...cle.com>
CC:	<airlied@...ux.ie>, <alexander.deucher@....com>,
	<j.glisse@...il.com>, <linux-kernel@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>, <John.Bridgman@....com>,
	<Andrew.Lewycky@....com>, <joro@...tes.org>
Subject: Re: [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask



On 12/03/2014 04:26 PM, Sasha Levin wrote:
> All the bit operations (such as find_first_zero_bit()) read sizeof(long) bytes
> at a time. If we allocated less than sizeof(long) bytes for the bitmask we
> would be accessing invalid memory when working with the bitmask.
>
> Change the allocator to allocate sizeof(long) multiples for the bitmask.
>
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> index 2458ab7..71699ad 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> @@ -32,8 +32,7 @@ int kfd_pasid_init(void)
>   {
>   	pasid_limit = max_num_of_processes;
>
> -	pasid_bitmap = kzalloc(DIV_ROUND_UP(pasid_limit, BITS_PER_BYTE),
> -				GFP_KERNEL);
> +	pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
>   	if (!pasid_bitmap)
>   		return -ENOMEM;
>
>

Thanks!
Applied to my -next tree.

Oded
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/