lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 04 Dec 2014 16:41:41 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	j.glisse@...il.com, linux-kernel@...r.kernel.org
CC:	Jérôme Glisse <jglisse@...hat.com>
Subject: Re: [PATCH] scripts/package: binrpm-pkg do not create source and
 devel package v3

On 2014-12-02 21:45, j.glisse@...il.com wrote:
> From: Jérôme Glisse <jglisse@...hat.com>
> 
> When doing make binrpm-pkg we only want to build the binary and header
> package as the documentation of binrpm-pkg target claims. Hence this
> patch avoid building the source and devel package. This makes binrpm-pkg
> target lot faster and way more usefull.
> 
> Changed since v2 :
>   - Avoid symlinks in /usr/src/kernel.
>   - Update subject line and changelog.

Thanks, much better!


>  echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/{build,source}"
>  echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE"

One last nitpick, then I'll merge the patch (promise!) -- the
/usr/src/kernels/$KERNELRELEASE directory is not needed and in fact the
rm -f above is also irrelevant. So please wrap the whole block in if !
$PREBUILT.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ