linux-kernel - Re: [PATCH] misc: suppress build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Dec 2014 08:30:32 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: suppress build warning

On Thu, Dec 04, 2014 at 03:13:00PM +0000, Prabhakar Lad wrote:
> On Thu, Dec 4, 2014 at 2:59 PM, Arnd Bergmann <arnd@...db.de> wrote:
> > On Thursday 04 December 2014 14:38:30 Lad, Prabhakar wrote:
> >> this patch fixes following build warning:
> >>
> >> drivers/misc/ioc4.c: In function ‘ioc4_probe’:
> >> drivers/misc/ioc4.c:194:16: warning: ‘start’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>   period = (end - start) /
> >>                 ^
> >> drivers/misc/ioc4.c:148:11: note: ‘start’ was declared here
> >>   uint64_t start, end, period;
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> >
> > Please explain why the compiler thinks there is a bug, why you
> > are sure that there isn't, and why you picked '0' as the
> > initialization value.
> >
> Its a false positive, to suppress the warning '0' was picked.

Are you _sure_ it's a false positive?  That odd do/while loop looks like
it might just not ever initialize the start variable, are you sure the
logic there is correct?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/