linux-kernel - Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141204174642.GA7944@katana>
Date:	Thu, 4 Dec 2014 18:46:42 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	linuxppc-dev@...abs.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach
	adapter


> > +
> > +	/* We assume Macs have consecutive I2C bus numbers starting at 0 */
> > +	while (adap) {
> > +		err = keywest_attach_adapter(adap);
> > +		if (!err)
> > +			break;
> > +		i2c_put_adapter(adap);
> > +		adap = i2c_get_adapter(++i);
> > +	}
> > +
> >  	return 0;
> 
> What if adap is NULL in the last while loop?  Isn't it supposed to
> return an error?

True, we probably should have something like

	return adap ? 0 : -ENODEV;

Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)