linux-kernel - Re: [PATCH 1/1] Staging: ft1000: fix some coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1417658309.2902.29.camel@perches.com>
Date:	Wed, 03 Dec 2014 17:58:29 -0800
From:	Joe Perches <joe@...ches.com>
To:	Kevin Pietsch <kevinpietsch@...il.com>
Cc:	Marek Belisko <marek.belisko@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: ft1000: fix some coding style issues

On Wed, 2014-12-03 at 20:49 -0500, Kevin Pietsch wrote:
> Removed braces from two single line if-else statements

Another perhaps better option is to use ?: like:
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index 0038a3a..8743516 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -172,11 +172,8 @@ u16 ft1000_read_dpram_mag_16(struct net_device *dev, int offset, int Index)
 	spin_lock_irqsave(&info->dpram_lock, flags);
 	ft1000_write_reg(dev, FT1000_REG_DPRAM_ADDR, offset);
 	/* check if we want to read upper or lower 32-bit word */
-	if (Index) {
-		data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAL);
-	} else {
-		data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAH);
-	}
+	data = ft1000_read_reg(dev, index ? FT1000_REG_MAG_DPDATAL
+					  : FT1000_REG_MAG_DPDATAH);
 	spin_unlock_irqrestore(&info->dpram_lock, flags);
 
 	return data;
@@ -204,11 +201,8 @@ static inline void ft1000_write_dpram_mag_16(struct net_device *dev,
 	/* Provide mutual exclusive access while reading ASIC registers. */
 	spin_lock_irqsave(&info->dpram_lock, flags);
 	ft1000_write_reg(dev, FT1000_REG_DPRAM_ADDR, offset);
-	if (Index) {
-		ft1000_write_reg(dev, FT1000_REG_MAG_DPDATAL, value);
-	} else {
-		ft1000_write_reg(dev, FT1000_REG_MAG_DPDATAH, value);
-	}
+	ft1000_write_reg(dev, index ? FT1000_REG_MAG_DPDATAL
+				    : FT1000_REG_MAG_DPDATAH, value);
 	spin_unlock_irqrestore(&info->dpram_lock, flags);
 }
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/