lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Dec 2014 00:44:07 -0800 From: Joe Perches <joe@...ches.com> To: Tristan Lelong <tristan@...ong.xyz> Cc: oleg.drokin@...el.com, andreas.dilger@...el.com, gregkh@...uxfoundation.org, askb23@...il.com, john.hammond@...el.com, gdonald@...il.com, anhlq2110@...il.com, fabio.falzoi84@...il.com, oort10@...il.com, agimenez@...valve.es, rupran@...server.de, surya.seetharaman9@...il.com, Julia.Lawall@...6.fr, a.terekhov@...il.com, liang.zhen@...el.com, vthakkar1994@...il.com, amk@...y.com, srikrishanmalik@...il.com, rd@...ekdostal.com, bergwolf@...il.com, dan.carpenter@...cle.com, paul.gortmaker@...driver.com, tapaswenipathak@...il.com, email@...istophjaeger.info, uja.ornl@...il.com, brilliantov@...ox.ru, dmitry.eremin@...el.com, HPDD-discuss@...ts.01.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: [] > > > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c [] > > > + char name[80]; [] > > Why 80? Is there no #define for this length? > > > No, there is no define. > > I thought about adding one, but several other files and structure > members in the lustre sources are using this specific value, and it > seemed like a modification to do in another patch. > > Let me know if you feel I should do it in a patch serie. No worries if it's not a new number. It'd be nice if you would submit a new patch with a #define and a conversion to use the #define one day. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists