linux-kernel - Re: [PATCH] staging: kernel: fixed style warnings in acct.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Dec 2014 03:04:12 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	"Joshua I. James" <joshua@...ercrimetech.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: kernel: fixed style warnings in acct.c

Joshua,

On Fri, Dec 05, 2014 at 01:47:34PM +0900, Joshua I. James wrote:
> From: "Joshua I. James" <joshua@...ercrimetech.com>
> 
> Fixed style errors identified by checkpatch.
> 
> Output of checkpatch:
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> ERROR: spaces required around that '==' (ctx:VxV)
> +#if ACCT_VERSION==2
> 

It looks like your patch is making three types of changes. A single
patch should make a single type of change.  For example, you might fix
all the "blank line after declaration" warnings in one patch.

Doing this helps make your patches easier to review, and if a problem
arises later, easier to bisect.

> Signed-off-by: Joshua I. James <joshua@...ercrimetech.com>
> ---
>  kernel/acct.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 33738ef..322159c 100644
> --- a/kernel/acct.c
[...]

It also looks like you only sent this to the linux-kernel mailing list.
You should use scripts/get_maintainer.pl to find who to send it to.

Hope that helps :-)

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/