linux-kernel - Re: drm/i915: Fix missing unlock on error in i915_gem_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1417781823-23283-1-git-send-email-jani.nikula@intel.com>
Date:	Fri,  5 Dec 2014 14:17:02 +0200
From:	Jani Nikula <jani.nikula@...el.com>
To:	intel-gfx@...ts.freedesktop.org,
	Jeremiah Mahler <jmmahler@...il.com>, weiyj_lk@....com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()

On Fri, 05 Dec 2014, Jeremiah Mahler <jmmahler@...il.com> wrote:
> There are other places in i915_gem_init_hw() where it returns without
> unlocking the mutex.  Why is it only necessary here and not any of the
> other places?

There's probably some rebase/merge confusion going on. The following
patch is against drm-intel-next-queued where the problem is
present. Thanks for reporting this.

BR,
Jani.


Jani Nikula (1):
  drm/i915: release struct_mutex on the i915_gem_init_hw fail path

 drivers/gpu/drm/i915/i915_gem.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/