linux-kernel - Re: [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5481140F.60607@cn.fujitsu.com>
Date:	Fri, 5 Dec 2014 10:10:23 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread()

On 12/04/2014 11:14 PM, Tejun Heo wrote:
> rescuer_thread() caches &rescuer->scheduled in a local variable
> scheduled for convenience.  There's one WARN_ON_ONCE() which was using
> &rescuer->scheduled directly.  Replace it with the local variable.
> 
> This patch causes no functional difference.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---

Reviewed-by: Lai Jiangshan <laijs@...fujitsu.com>


> Applying to wq/for-3.19.
> 
> Thanks.
> 
>  kernel/workqueue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2246,7 +2246,7 @@ repeat:
>  		 * Slurp in all works issued via this workqueue and
>  		 * process'em.
>  		 */
> -		WARN_ON_ONCE(!list_empty(&rescuer->scheduled));
> +		WARN_ON_ONCE(!list_empty(scheduled));
>  		list_for_each_entry_safe(work, n, &pool->worklist, entry)
>  			if (get_work_pwq(work) == pwq)
>  				move_linked_works(work, scheduled, &n);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/