linux-kernel - Re: [PATCHv5 2/3] kernel: add support for live patching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141205195013.GA16916@treble.redhat.com>
Date:	Fri, 5 Dec 2014 13:50:13 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Seth Jennings <sjenning@...hat.com>, Jiri Kosina <jkosina@...e.cz>,
	Vojtech Pavlik <vojtech@...e.cz>,
	Steven Rostedt <rostedt@...dmis.org>,
	Petr Mladek <pmladek@...e.cz>, Miroslav Benes <mbenes@...e.cz>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Christoph Hellwig <hch@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Andy Lutomirski <luto@...capital.net>,
	live-patching@...r.kernel.org, x86@...nel.org, kpatch@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 2/3] kernel: add support for live patching

On Fri, Dec 05, 2014 at 06:55:04PM +0100, Jiri Slaby wrote:
> On 12/04/2014, 04:53 PM, Seth Jennings wrote:
> ...
> > --- /dev/null
> > +++ b/kernel/livepatch/core.c
> > @@ -0,0 +1,902 @@
> ...
> > +static struct kobj_type klp_ktype_patch = {
> > +	.sysfs_ops = &kobj_sysfs_ops,
> > +	.default_attrs = klp_patch_attrs
> > +};
> 
> Hi, I seem to have only a single comment here. If I am looking
> correctly, the last put on this kobject will cause kobject_cleanup to
> generate a warning:
>    "kobject: '%s' (%p): does not have a release() "
>    "function, it is broken and must be fixed.\n",
> 
> There should be some .release. IMO, this is a place where we will
> release the module with the patch. So the .release hook should contain
> something like a commented out module_put() with a pointer to
> klp_register_patch. (Or be empty at worst.)

Ok, thanks.

BTW, Seth will be out for at least the next week.  I'll take over the
patch set until he returns.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/