linux-kernel - Re: [PATCH 0/3] Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3160202.BXgrhrDjJo@xps13>
Date:	Fri, 05 Dec 2014 21:53:10 +0100
From:	Gabriele Mazzotta <gabriele.mzt@...il.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	Alex Hung <alex.hung@...onical.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Dell Airplane Mode Switch driver

On Friday 05 December 2014 21:38:17 Pali Rohár wrote:
> On Wednesday 03 December 2014 14:00:23 Darren Hart wrote:
> > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote:
> > > Darren, I think that if we do not solve problem with
> > > duplicate key events (in dell-wireless.c) we should
> > > postpone these patches to later kernel version. It is
> > > better to not have such regression as it confuse software
> > > like NetworkManager which is widely used.
> > 
> > OK, that's what I needed. Thanks. Ignore my previous request,
> > you answered it here. I will drop dell-wireless.c and look
> > for a combined solution from you and Alex for the next
> > release.
> > 
> > Thanks,
> 
> And according to discussion about Side effect of pressing special
> keys at [1] [2] we should not report this wireless key event (as
> input device) to userspace. And Alex's driver is doing that.
> 
> [1] - http://www.spinics.net/lists/platform-driver-x86/msg05922.html
> [2] - http://www.spinics.net/lists/platform-driver-x86/msg05924.html

Alex's patch is for those laptop whose BIOS only sends a notification to
DELLABCE when Fn keys are pressed. His patch simply translates these ACPI
notifications to KEY_RFKILL keypresses.

Correct if I'm wrong, but shouldn't his patch have no effects on your
laptop? If I'm not wrong, CRBT returns 2 on your laptop, so the input
device is not even created. Am I missing something?

Gabriele
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/