linux-kernel - Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141205134455.7901c40277cbc2093ccabfd2@linux-foundation.org>
Date:	Fri, 5 Dec 2014 13:44:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Stefan Agner <stefan@...er.ch>
Cc:	Sanchayan Maity <maitysanchayan@...il.com>, a.zummo@...ertech.it,
	rtc-linux@...glegroups.com, shawn.guo@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

On Fri, 05 Dec 2014 15:54:15 +0100 Stefan Agner <stefan@...er.ch> wrote:

> It can be fixed, with something like this:
> 
> @@ -346,7 +347,10 @@ static int snvs_rtc_resume(struct device *dev)
>  }
>  #endif
>  
> -static SIMPLE_DEV_PM_OPS(snvs_rtc_pm_ops, snvs_rtc_suspend,
> snvs_rtc_resume);
> +static const struct dev_pm_ops snvs_rtc_pm_ops = {
> +       .suspend_noirq = snvs_rtc_suspend,
> +       .resume_noirq = snvs_rtc_resume,
> +};
>  
>  static const struct of_device_id snvs_dt_ids[] = {
>         { .compatible = "fsl,sec-v4.0-mon-rtc-lp", },
> 
> 
> 
> Andrew, this patch is already merged, so it would need another fix for
> this, right?

A replacement patch is OK.  An incremental patch is OK too.  I almost
always turn the replacement into an incremental so that I and others
can see what changed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/