linux-kernel - Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6ry0WBwcqH74sub-C=e0oGsPEoqXZ4O7uAwGcJC9Zc2zJw@mail.gmail.com>
Date:	Fri, 5 Dec 2014 23:30:00 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Graham Moore <grmoore@...nsource.altera.com>
Cc:	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Alan Tull <atull@...nsource.altera.com>,
	Yves Vandervennet <yvanderv@...nsource.altera.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.

On 5 December 2014 at 20:35, Graham Moore <grmoore@...nsource.altera.com> wrote:
> +               if (of_modalias_node(np, modalias, sizeof(modalias)) < 0)
> +                       goto probe_failed;
> +
> +               ret = spi_nor_scan(nor, modalias, SPI_NOR_QUAD);
> +               if (ret)
> +                       goto probe_failed;
> (...)
> +
> +static struct of_device_id cqspi_dt_ids[] = {
> +       {.compatible = "cdns,qspi-nor",},
> +       { /* end of table */ }
> +};

AFAIU of_modalias_node will give you "qspi-nor" string. Second
argument passed to the spi_nor_scan is a chip name you expect on the
device. Of course passing "qspi-nor" (if I'm right about
of_modalias_node) doesn't make any sense.

Since my commit
mtd: spi-nor: allow NULL as chip name and try to auto detect it
second argument is optional.

Can you simply pass NULL instead of modalias?

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/