linux-kernel - Re: [PATCH v2 2/3] toshiba_acpi: Change notify funtion to handle more events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGdLNWFpvSLZorQ6WNpEBZ+rkxcP7CR0vxtW4ugmyxojNRWLVg@mail.gmail.com>
Date:	Thu, 4 Dec 2014 20:10:49 -0700
From:	Azael Avalos <coproscefalo@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] toshiba_acpi: Change notify funtion to handle more events

Hi Darren,

2014-12-03 6:12 GMT-07:00 Darren Hart <dvhart@...radead.org>:
> On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
>> @@ -1971,41 +2008,22 @@ error:
>>  static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>>  {
>>       struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
>> -     u32 hci_result, value;
>> -     int retries = 3;
>> -     int scancode;
>> -
>> -     if (event != 0x80)
>> -             return;
>> +     int ret;
>
>   CC      drivers/platform/x86/toshiba_acpi.o
> drivers/platform/x86/toshiba_acpi.c: In function ‘toshiba_acpi_notify’:
> drivers/platform/x86/toshiba_acpi.c:2012:6: warning: unused variable ‘ret’ [-Wunused-variable]
>     int ret;
>           ^
>
> Please compile check each patch.

Sorry about that, was a left over from the split.
Want me to send a V3? I can send them in few minutes.

>
> --
> Darren Hart
> Intel Open Source Technology Center



-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/