linux-kernel - Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Dec 2014 22:27:06 -0500
From:	Dan Streetman <ddstreet@...e.org>
To:	Ashutosh Dixit <ashutosh.dixit@...el.com>
Cc:	Jonathan Corbet <corbet@....net>, Jiri Kosina <jkosina@...e.cz>,
	Peter Foley <pefoley2@...oley.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jennings <sjennings@...iantweb.net>,
	Caz Yokoyama <Caz.Yokoyama@...el.com>,
	Sudeep Dutt <sudeep.dutt@...el.com>,
	Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-doc@...r.kernel.org, Nikhil Rao <nikhil.rao@...el.com>,
	Daniel Borkmann <dborkman@...hat.com>,
	linuxppc-dev@...ts.ozlabs.org,
	Siva Yerramreddy <yshivakrishna@...il.com>
Subject: Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit <ashutosh.dixit@...el.com> wrote:
> mic/mpssd along with MIC drivers are currently only usable on
> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on
> big-endian systems.

Only building for x86_64 is fine, but in that case what's the point of
leaving the htole16() et. al. functions in mpssd.c?  Shouldn't they be
removed?

>
> Reported-by: Daniel Borkmann <dborkman@...hat.com>
> Reported-by: Dan Streetman <ddstreet@...il.com>
> Suggested-by: Peter Foley <pefoley2@...oley.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@...el.com>
> ---
>  Documentation/mic/mpssd/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mic/mpssd/Makefile b/Documentation/mic/mpssd/Makefile
> index 0f31568..f47fe6b 100644
> --- a/Documentation/mic/mpssd/Makefile
> +++ b/Documentation/mic/mpssd/Makefile
> @@ -1,5 +1,5 @@
>  # List of programs to build
> -hostprogs-y := mpssd
> +hostprogs-$(CONFIG_X86_64) := mpssd
>
>  mpssd-objs := mpssd.o sysfs.o
>
> --
> 2.0.0.rc3.2.g998f840
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/