linux-kernel - Re: [BUG] kzalloc overflow in lpfc driver on 6k core system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <548363B5.1040909@emulex.com>
Date:	Sat, 6 Dec 2014 15:14:45 -0500
From:	James Smart <james.smart@...lex.com>
To:	Alex Thorlton <athorlton@....com>
CC:	"Elliott, Robert (Server Storage)" <Elliott@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [BUG] kzalloc overflow in lpfc driver on 6k core system

Alex,

Myself and several others here at Emulex maintain the code. The 
recommendations look fine.   Feel free to post something if you beat us 
to the work.

-- james s


On 12/3/2014 11:05 AM, Alex Thorlton wrote:
> On Tue, Dec 02, 2014 at 10:39:40PM +0000, Elliott, Robert (Server Storage) wrote:
>> In similar code, mpt3sas and lockless hpsa just call get_cpu_mask()
>> inside the loop:
>>          cpu = cpumask_first(cpu_online_mask);
>>          for (i = 0; i < h->msix_vector; i++) {
>>                  rc = irq_set_affinity_hint(h->intr[i], get_cpu_mask(cpu));
>>                  cpu = cpumask_next(cpu, cpu_online_mask);
>>          }
>>
>> get_cpu_mask() uses the global cpu_bit_bitmap array, which is declared
>> in kernel/cpu.c:
>> extern const unsigned long
>>          cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)];
>>
>> That approach should work for lpfc.
> Ok, good deal.  Thanks for the info, Robert.  Do you know who the
> current maintainer is for this code?  Would that be you?  I included the
> two authors that get_maintainer reported, but haven't heard from them.
>
> I like this approach and don't mind implementing it myself, but I'd like
> to confirm that whoever would be responsible for merging the code is ok
> with the change before going forward.  Of course, if the code has been
> orphaned, then I guess we just write away :)
>
> Thanks again for the help!
>
> - Alex
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/