linux-kernel - Re: [PATCH] staging: lustre: replace static value with define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 6 Dec 2014 14:41:17 -0800
From:	Tristan Lelong <tristan@...ong.xyz>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
Cc:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"standby24x7@...il.com" <standby24x7@...il.com>,
	"askb23@...il.com" <askb23@...il.com>,
	"Hammond, John" <john.hammond@...el.com>,
	"bergwolf@...il.com" <bergwolf@...il.com>,
	"Wang, Di" <di.wang@...el.com>,
	"Pershin, Mike" <mike.pershin@...el.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: replace static value with define

On Sat, Dec 06, 2014 at 05:09:29PM +0000, Dilger, Andreas wrote:
> > 
> >diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >index 74b4db9..7a55941 100644
> >--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >+++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >@@ -96,7 +96,7 @@ fld_proc_hash_seq_write(struct file *file,
> > 	char *name;
> > 	int i;
> > 
> >-	if (count > 80)
> >+	if (count > LUSTRE_MDT_MAXNAMELEN)
> > 		return -ENAMETOOLONG;
> 
> Sorry for the late reply, but this has nothing to do with an MDT service
> name, so using this #define is misleading here.  As I wrote in my other
> email, this only needs to be at most 8 characters.
> 

I see that now, I will change that according to the other email.

Do you want me to redo this patch and still define the 80 as LUSTRE_MDT_MAXNAMELEN
but without this last part (just the define and the string length declaration), or
should we just let this go?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/