linux-kernel - [PATCH] VERIFY_OCTAL_PERMISSIONS needs <linux/bug.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141206000759.14606.qmail@ns.horizon.com>
Date:	5 Dec 2014 19:07:59 -0500
From:	"George Spelvin" <linux@...izon.com>
To:	rusty@...tcorp.com.au
Cc:	akpm@...ux-foundation.org, linux@...izon.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] VERIFY_OCTAL_PERMISSIONS needs <linux/bug.h>

It is possible to include <linux/kernel.h> and try to use
VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO
isn't defined.

I hit this via:

#include <linux/moduleparam.h>
module_param(verbose, bool, 0);

IMHO, except in documented special cases, header files should
#include their own macros' dependencies.

Signed-off-by: George Spelvin <linux@...izon.com>
---
 include/linux/kernel.h | 1 +
 1 file changed, 1 insertion(+)

I'm not quite sure who to send this via.  Rusty, you touched
VERIFY_OCTAL_PERMISSIONS last.  Should I send this via you, or collect
acks and include it in the patch series I'm working on that wants this?

The workaround is easy enough, but I'd rather fix it than let cruft
like this accumulate.

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 3d770f55..afb81c1a 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -12,6 +12,7 @@
 #include <linux/typecheck.h>
 #include <linux/printk.h>
 #include <linux/dynamic_debug.h>
+#include <linux/bug.h>
 #include <asm/byteorder.h>
 #include <uapi/linux/kernel.h>

-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/