linux-kernel - RE: drivers:scsi:storvsc: Fix a bug in handling ring buffer failures that may result in I/O freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB0711D4CE74D3EFA7FB8D346BA0660@BY2PR0301MB0711.namprd03.prod.outlook.com>
Date:	Sat, 6 Dec 2014 02:40:51 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Long Li <longli@...rosoft.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:	Haiyang Zhang <haiyangz@...rosoft.com>,
	"JBottomley@...allels.com" <JBottomley@...allels.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Long Li <longli@...rosoft.com>
Subject: RE: drivers:scsi:storvsc: Fix a bug in handling ring buffer failures
 that may result in I/O freeze



> -----Original Message-----
> From: Long Li [mailto:longli@...rosoft.com]
> Sent: Friday, December 5, 2014 7:38 PM
> To: linux-scsi@...r.kernel.org
> Cc: KY Srinivasan; Haiyang Zhang; JBottomley@...allels.com;
> devel@...uxdriverproject.org; linux-kernel@...r.kernel.org; Long Li
> Subject: drivers:scsi:storvsc: Fix a bug in handling ring buffer failures that may
> result in I/O freeze
> 
> When ring buffer returns an error indicating retry, storvsc may not return a
> proper error code to SCSI when bounce buffer is not used. This has
> introduced I/O freeze on RAID running atop storvsc devices. This patch fixes
> it by always returning a proper error code.
> 
> Signed-off-by: Long Li <longli@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
cc: stable@...r.kernel.org

> ---
>  drivers/scsi/storvsc_drv.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index
> e3ba251..4cff0dd 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1688,13 +1688,12 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
>  	if (ret == -EAGAIN) {
>  		/* no more space */
> 
> -		if (cmd_request->bounce_sgl_count) {
> +		if (cmd_request->bounce_sgl_count)
>  			destroy_bounce_buffer(cmd_request->bounce_sgl,
>  					cmd_request->bounce_sgl_count);
> 
> -			ret = SCSI_MLQUEUE_DEVICE_BUSY;
> -			goto queue_error;
> -		}
> +		ret = SCSI_MLQUEUE_DEVICE_BUSY;
> +		goto queue_error;
>  	}
> 
>  	return 0;
> --
> 2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/