[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20141205161548.dfa3bc0648b2109ebed9b1ae@linux-foundation.org>
Date: Fri, 5 Dec 2014 16:15:48 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "George Spelvin" <linux@...izon.com>
Cc: rusty@...tcorp.com.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VERIFY_OCTAL_PERMISSIONS needs <linux/bug.h>
On 5 Dec 2014 19:07:59 -0500 "George Spelvin" <linux@...izon.com> wrote:
> It is possible to include <linux/kernel.h> and try to use
> VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO
> isn't defined.
>
> I hit this via:
>
> #include <linux/moduleparam.h>
> module_param(verbose, bool, 0);
>
> IMHO, except in documented special cases, header files should
> #include their own macros' dependencies.
>
> Signed-off-by: George Spelvin <linux@...izon.com>
> ---
> include/linux/kernel.h | 1 +
> 1 file changed, 1 insertion(+)
>
> I'm not quite sure who to send this via. Rusty, you touched
> VERIFY_OCTAL_PERMISSIONS last. Should I send this via you, or collect
> acks and include it in the patch series I'm working on that wants this?
>
> The workaround is easy enough, but I'd rather fix it than let cruft
> like this accumulate.
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index 3d770f55..afb81c1a 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -12,6 +12,7 @@
> #include <linux/typecheck.h>
> #include <linux/printk.h>
> #include <linux/dynamic_debug.h>
> +#include <linux/bug.h>
> #include <asm/byteorder.h>
> #include <uapi/linux/kernel.h>
Absolutely everything includes kernel.h so this might have measurable
build-time impact.
VERIFY_OCTAL_PERMISSIONS() sticks out like a sore thumb in kernel.h.
How about we move it into sysfs.h?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists