[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1417839402-13490-7-git-send-email-akong@redhat.com>
Date: Sat, 6 Dec 2014 12:16:42 +0800
From: Amos Kong <akong@...hat.com>
To: virtualization@...ts.linux-foundation.org, rusty@...tcorp.com.au
Cc: kvm@...r.kernel.org, m@...s.ch, mpm@...enic.com,
amit.shah@...hat.com, linux-kernel@...r.kernel.org,
herbert@...dor.apana.org.au
Subject: [PATCH v5 6/6] hw_random: don't init list element we're about to add to list.
From: Rusty Russell <rusty@...tcorp.com.au>
Another interesting anti-pattern.
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index a9286bf..4d13ac5 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -489,7 +489,6 @@ int hwrng_register(struct hwrng *rng)
goto out_unlock;
}
}
- INIT_LIST_HEAD(&rng->list);
list_add_tail(&rng->list, &rng_list);
if (old_rng && !rng->init) {
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists