linux-kernel - Re: [PATCH 8/20] USB: isp1760: fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141207204811.GC5360@hudson.localdomain>
Date:	Sun, 7 Dec 2014 12:48:11 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/20] USB: isp1760: fix misspelling of current function
 in string

Julia,

On Sun, Dec 07, 2014 at 09:45:15PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 7 Dec 2014, Jeremiah Mahler wrote:
> 
> > Julia,
> > 
> > On Sun, Dec 07, 2014 at 08:20:50PM +0100, Julia Lawall wrote:
> > > Replace a misspelled function name by %s and then __func__.
[...]
> > >  
> > >  static void isp1761_pci_shutdown(struct pci_dev *dev)
> > >  {
> > > -	printk(KERN_ERR "ips1761_pci_shutdown\n");
> > > +	printk(KERN_ERR "%s\n", __func__);
> > >  }
> > >  
> > You can also switch from printk to pr_err and that would fix thte
> > checkpatch warning for this patch.
> 
> Yeah, I didn't want to do too much at once, since tha could be done all at 
> once in a lot of other places too.  But I will fix up this one.
> 
> julia
> 

I agree, doing too much at once is usually bad.  But these are pretty
small and it is good if your patch doesn't have any checkpatch issues.

> > >  static const struct pci_device_id isp1760_plx [] = {
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> > > the body of a message to majordomo@...r.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > -- 
> > - Jeremiah Mahler
> > --
> > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/