linux-kernel - Re: [PATCH 19/20] TTY: fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1412072201430.2235@localhost6.localdomain6>
Date:	Sun, 7 Dec 2014 22:05:10 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Jeremiah Mahler <jmmahler@...il.com>
cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20] TTY: fix misspelling of current function in
 string

On Sun, 7 Dec 2014, Jeremiah Mahler wrote:

> Julia,
> 
> On Sun, Dec 07, 2014 at 08:21:01PM +0100, Julia Lawall wrote:
> > Replace a misspelled function name by %s and then __func__.
> > 
> > This was done using Coccinelle, including the use of Levenshtein distance,
> > as proposed by Rasmus Villemoes.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> > 
> > ---
> > The semantic patch is difficult to summarize, but is available in the cover
> [...]
> > @@ -1458,7 +1458,7 @@ static void rp_wait_until_sent(struct tty_struct *tty, int timeout)
> >  
> >  	orig_jiffies = jiffies;
> >  #ifdef ROCKET_DEBUG_WAIT_UNTIL_SENT
> > -	printk(KERN_INFO "In RP_wait_until_sent(%d) (jiff=%lu)...\n", timeout,
> > +	printk(KERN_INFO "In %s(%d) (jiff=%lu)...\n", __func__, timeout,
> >  	       jiffies);
> >  	printk(KERN_INFO "cps=%d...\n", info->cps);
> >  #endif
> > 
> More printk, pr_info, I'm sure you get the idea :-)

Well, these are drivers, so it should probably be dev_info, etc.

I have the impression that satisfying checkpatch would require a more 
complicated change than the original patch.

I would still find it better to makes these changes in another patch 
series.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/