linux-kernel - Re: [PATCH 1/8] perf tools: Add feature check for libbabeltrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cixHgGqiLu0c8zrbEU6aLNdvhwC0vne4zcd8OZjQkCV1Q@mail.gmail.com>
Date:	Mon, 8 Dec 2014 17:07:23 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeremie Galarneau <jgalar@...icios.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 1/8] perf tools: Add feature check for libbabeltrace

Hi Jiri,

On Thu, Dec 4, 2014 at 1:23 AM, Jiri Olsa <jolsa@...nel.org> wrote:
> +ifndef NO_LIBBABELTRACE
> +  # for linking with debug library, run like:
> +  # make DEBUG=1 LIBBABELTRACE_DIR=/opt/libdw/

s/libdw/libbabeltrace/


> +  ifdef LIBBABELTRACE_DIR
> +    LIBBABELTRACE_CFLAGS  := -I$(LIBBABELTRACE_DIR)/include
> +    LIBBABELTRACE_LDFLAGS := -L$(LIBBABELTRACE_DIR)/lib
> +  endif
> +  FEATURE_CHECK_CFLAGS-libbabeltrace := $(LIBBABELTRACE_CFLAGS)
> +  FEATURE_CHECK_LDFLAGS-libbabeltrace := $(LIBBABELTRACE_LDFLAGS) -lbabeltrace-ctf
> +endif
> +
>  # include ARCH specific config
>  -include $(src-perf)/arch/$(ARCH)/Makefile
>
> @@ -201,6 +212,7 @@ CORE_FEATURE_TESTS =                        \
>         stackprotector-all              \
>         timerfd                         \
>         libdw-dwarf-unwind              \
> +       libbabeltrace                   \
>         zlib
>
>  LIB_FEATURE_TESTS =                    \
> @@ -216,6 +228,7 @@ LIB_FEATURE_TESTS =                 \
>         libslang                        \
>         libunwind                       \
>         libdw-dwarf-unwind              \
> +       libbabeltrace                   \
>         zlib
>
>  VF_FEATURE_TESTS =                     \
> @@ -661,6 +674,17 @@ else
>    NO_PERF_READ_VDSOX32 := 1
>  endif
>
> +ifndef NO_LIBBABELTRACE
> +  ifeq ($(feature-libbabeltrace), 0)
> +    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-devel/libbabeltrace-dev);

It seems that Ubuntu has libbabeltrace-ctf-dev package.

Thanks,
Namhyung


> +    NO_LIBBABELTRACE := 1
> +  else
> +    CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
> +    LDFLAGS += $(LIBBABELTRACE_LDFLAGS)
> +    EXTLIBS += -lbabeltrace-ctf
> +  endif
> +endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/