linux-kernel - Re: [PATCH v2] Drivers: memstick: host: Fixed missing a blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141208081439.GA3951@x1>
Date:	Mon, 8 Dec 2014 08:14:39 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Athira Lekshmi <andnlnbn18@...il.com>
Cc:	rogerable@...ltek.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Drivers: memstick: host: Fixed missing a blank line
 warning

Not a bad attempt.

The subject line should match the subsystem.  You can see what that is
by issuing `git log --oneline -- drivers/memstick/` (supplement
drivers/memstick for the subsystem that you're submitting to).

> Added a new line after declaration to fix the warning message
> 'Missing a blank line after declarations'
> 
> Signed-off-by: Athira Lekshmi <andnlnbn18@...il.com>
> ---
>  drivers/memstick/host/rtsx_usb_ms.c |    1 +
>  1 file changed, 1 insertion(+)

Apart from my comment at the top (which a kind maintainer can fix for
you on this occasion I'm sure ;) ), the patch looks good:

Acked-by: Lee Jones <lee.jones@...aro.org>

Now make 3 such changes (you can use checkpatch on some other files)
and send them as a patch-set.

> diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
> index a7282b7..cefd745 100644
> --- a/drivers/memstick/host/rtsx_usb_ms.c
> +++ b/drivers/memstick/host/rtsx_usb_ms.c
> @@ -59,6 +59,7 @@ static inline struct device *ms_dev(struct rtsx_usb_ms *host)
>  static inline void ms_clear_error(struct rtsx_usb_ms *host)
>  {
>  	struct rtsx_ucr *ucr = host->ucr;
> +
>  	rtsx_usb_ep0_write_register(ucr, CARD_STOP,
>  				  MS_STOP | MS_CLR_ERR,
>  				  MS_STOP | MS_CLR_ERR);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/