linux-kernel - Re: [PATCH 6/20] TTY: fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <548565FC.1020908@suse.cz>
Date:	Mon, 08 Dec 2014 09:49:00 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Julia Lawall <Julia.Lawall@...6.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	kernel-janitors@...r.kernel.org, linux@...musvillemoes.dk,
	joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/20] TTY: fix misspelling of current function in string

On 12/07/2014, 08:20 PM, Julia Lawall wrote:
> Replace the last argument of serial_paranoia_check by the actual function
> name.
> 
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
> 
>  drivers/tty/amiserial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index d9f85f9..b2d7600 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -931,7 +931,7 @@ static void rs_send_xchar(struct tty_struct *tty, char ch)
>  	struct serial_state *info = tty->driver_data;
>          unsigned long flags;
>  
> -	if (serial_paranoia_check(info, tty->name, "rs_send_char"))
> +	if (serial_paranoia_check(info, tty->name, "rs_send_xchar"))

I wonder, why not to use __func__ here too?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/