linux-kernel - [PATCH v5 REPOST 5/6] hw_random: don't double-check old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1418028640-4891-6-git-send-email-akong@redhat.com>
Date:	Mon,  8 Dec 2014 16:50:39 +0800
From:	Amos Kong <akong@...hat.com>
To:	linux-crypto@...r.kernel.org
Cc:	virtualization@...ts.linux-foundation.org,
	herbert@...dor.apana.org.au, rusty@...tcorp.com.au,
	kvm@...r.kernel.org, m@...s.ch, mpm@...enic.com,
	amit.shah@...hat.com, linux-kernel@...r.kernel.org
Subject: [PATCH v5 REPOST 5/6] hw_random: don't double-check old_rng.

From: Rusty Russell <rusty@...tcorp.com.au>

Interesting anti-pattern.

Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
---
 drivers/char/hw_random/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 067270b..a9286bf 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -476,14 +476,13 @@ int hwrng_register(struct hwrng *rng)
 	}
 
 	old_rng = current_rng;
+	err = 0;
 	if (!old_rng) {
 		err = hwrng_init(rng);
 		if (err)
 			goto out_unlock;
 		set_current_rng(rng);
-	}
-	err = 0;
-	if (!old_rng) {
+
 		err = register_miscdev();
 		if (err) {
 			drop_current_rng();
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/