linux-kernel - Re: [PATCH] gpu: drm: i915: intel_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d27uo2sp.fsf@intel.com>
Date:	Mon, 08 Dec 2014 12:26:30 +0200
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Daniel Vetter <daniel.vetter@...el.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	David Airlie <airlied@...ux.ie>,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: drm: i915: intel_dsi_cmd.c:  Remove unused function

On Sun, 07 Dec 2014, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:
> Remove the function dsi_hs_mode_enable() that is not used anywhere.

Please don't.

BR,
Jani.

>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/gpu/drm/i915/intel_dsi_cmd.c |   21 ---------------------
>  drivers/gpu/drm/i915/intel_dsi_cmd.h |    2 --
>  2 files changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_cmd.c b/drivers/gpu/drm/i915/intel_dsi_cmd.c
> index f4767fd..71addcc 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_cmd.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_cmd.c
> @@ -103,27 +103,6 @@ enum dsi_type {
>  	DSI_GENERIC,
>  };
>  
> -/* enable or disable command mode hs transmissions */
> -void dsi_hs_mode_enable(struct intel_dsi *intel_dsi, bool enable)
> -{
> -	struct drm_encoder *encoder = &intel_dsi->base.base;
> -	struct drm_device *dev = encoder->dev;
> -	struct drm_i915_private *dev_priv = dev->dev_private;
> -	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
> -	enum pipe pipe = intel_crtc->pipe;
> -	u32 temp;
> -	u32 mask = DBI_FIFO_EMPTY;
> -
> -	if (wait_for((I915_READ(MIPI_GEN_FIFO_STAT(pipe)) & mask) == mask, 50))
> -		DRM_ERROR("Timeout waiting for DBI FIFO empty\n");
> -
> -	temp = I915_READ(MIPI_HS_LP_DBI_ENABLE(pipe));
> -	temp &= DBI_HS_LP_MODE_MASK;
> -	I915_WRITE(MIPI_HS_LP_DBI_ENABLE(pipe), enable ? DBI_HS_MODE : DBI_LP_MODE);
> -
> -	intel_dsi->hs = enable;
> -}
> -
>  static int dsi_vc_send_short(struct intel_dsi *intel_dsi, int channel,
>  			     u8 data_type, u16 data)
>  {
> diff --git a/drivers/gpu/drm/i915/intel_dsi_cmd.h b/drivers/gpu/drm/i915/intel_dsi_cmd.h
> index 46aa1ac..7ad54c0 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_cmd.h
> +++ b/drivers/gpu/drm/i915/intel_dsi_cmd.h
> @@ -36,8 +36,6 @@
>  #define DPI_LP_MODE_EN	false
>  #define DPI_HS_MODE_EN	true
>  
> -void dsi_hs_mode_enable(struct intel_dsi *intel_dsi, bool enable);
> -
>  int dsi_vc_dcs_write(struct intel_dsi *intel_dsi, int channel,
>  		     const u8 *data, int len);
>  
> -- 
> 1.7.10.4
>

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/