linux-kernel - Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPTm99V1qP5dAgDV04i3m_yR1ri9h=b8fDXBDxmPfpZG_P268g@mail.gmail.com>
Date:	Mon, 8 Dec 2014 18:12:15 +0530
From:	Ankit Jindal <ankit.jindal@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Varka Bhadram <varkabhadram@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Anup Patel <anup@...infault.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"patches@....com" <patches@....com>,
	Rob Herring <robh+dt@...nel.org>,
	"Hans J. Koch" <hjk@...sjkoch.de>,
	Tushar Jagad <tushar.jagad@...aro.org>,
	Kumar Gala <galak@...eaurora.org>,
	Andreas Färber <afaerber@...e.de>
Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for
 X-Gene QMTM UIO driver

On 18 November 2014 at 18:40, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 18 November 2014 14:59:54 Ankit Jindal wrote:
>> On 17 November 2014 16:47, Arnd Bergmann <arnd@...db.de> wrote:
>> > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
>> >> +
>> >> +       qmtm1_uio: qmtm_uio@...00000 {
>> >> +               compatible = "apm,xgene-qmtm";
>> >> +               status = "disabled";
>> >> +               reg = <0x0 0x1f200000 0x0 0x10000>,
>> >> +                     <0x0 0x1b000000 0x0 0x400000>;
>> >> +               reg-names = "csr", "fabric";
>> >> +               qpool-memory = <&qmtm1_uio_qpool>;
>> >> +               clocks = <&qmtm1clk 0>;
>> >> +               num-queues = <0x400>;
>> >> +               devid = <1>;
>> >> +       };
>> >> +
>> >
>> > To make my previous review comments clearer:
>> >
>> > NAK
>> >
>> > Do not create device nodes that are meant for a specific use case in
>> > software and that are not usable for the common case. I don't think
>> > it makes any sense to keep on submitting a UIO driver for this until
>> > we have a proper network driver that uses this so we can make sure we
>> > have a working binding.
>>
>> The dataplane frameworks like OpenDataPlane etc, need to have access
>> to complete subsystem from the user space. Hence, we would like to
>> have this driver and some other UIO drivers to be the part of kernel
>> to have data plane frameworks working on our platform.
>
> Please work with the people that do the in-kernel QMTM driver to come
> up with a common binding then.
Thanks Arnd, I have synced with them, and in future our dt bindings
for this device is going to be inline with the one mentioned in the
patchset.
>
>         Arnd
Thanks,
Ankit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/