linux-kernel - Re: [GIT PULL] tracing/NMI/printk: Use seq_buf for safe printing from NMI context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Dec 2014 10:08:51 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jiri Kosina <jkosina@...e.cz>, Petr Mladek <pmladek@...e.cz>
Subject: Re: [GIT PULL] tracing/NMI/printk: Use seq_buf for safe printing
 from NMI context

On Mon, 8 Dec 2014 10:05:28 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:


> This code solves the issue of performing stack dumps from NMI context.
> The issue is that printk() is not safe from NMI context as if the NMI
> were to trigger when a printk() was being performed, the NMI could
> deadlock from the printk() internal locks. This has been seen in practice.
> 

One added bonus is that this code also makes the NMI dump stack work on
PREEMPT_RT kernels. As printk() includes sleeping locks on PREEMPT_RT,
printk() only writes to console if the console does not use any
rt_mutex converted spin locks. Which a lot do.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/