linux-kernel - Re: [PATCH] thermal: Fix error path in thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1418012224.19126.22.camel@rzhang1-toshiba>
Date:	Mon, 08 Dec 2014 12:17:04 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	Eduardo Valentin <edubezval@...il.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] thermal: Fix error path in thermal_init()

On Wed, 2014-12-03 at 21:20 +0000, Luis Henriques wrote:
> thermal_unregister_governors() and class_unregister() were being called in
> the wrong order.
> 
> Fixes: 80a26a5c22b9 ("Thermal: build thermal governors into thermal_sys module")
> Cc: stable@...r.kernel.org
> Signed-off-by: Luis Henriques <luis.henriques@...onical.com>

applied.

thanks,
rui
> ---
>  drivers/thermal/thermal_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 43b90709585f..488e9bfd996b 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1835,10 +1835,10 @@ static int __init thermal_init(void)
>  
>  exit_netlink:
>  	genetlink_exit();
> -unregister_governors:
> -	thermal_unregister_governors();
>  unregister_class:
>  	class_unregister(&thermal_class);
> +unregister_governors:
> +	thermal_unregister_governors();
>  error:
>  	idr_destroy(&thermal_tz_idr);
>  	idr_destroy(&thermal_cdev_idr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/